Stream: t-compiler/wg-meta

Topic: meeting 2019.10.24


Santiago Pastorino (Oct 24 2019 at 18:00, on Zulip):

@T-compiler/WG-meta :wave:

Santiago Pastorino (Oct 24 2019 at 18:00, on Zulip):

@nikomatsakis what I was mentioning you earlier was https://github.com/rust-lang/rustc-guide/issues/478

Santiago Pastorino (Oct 24 2019 at 18:01, on Zulip):

there's a missing link on the ice-breaker group, gonna wait for somebody to provide a PR, otherwise I'm gonna fix it

Santiago Pastorino (Oct 24 2019 at 18:01, on Zulip):

and also, saw a lot of PRs of people signing up to llvm-icebreakers

nikomatsakis (Oct 24 2019 at 18:01, on Zulip):

wow, quite some comments on that issue :)

nikomatsakis (Oct 24 2019 at 18:02, on Zulip):

and also, saw a lot of PRs of people signing up to llvm-icebreakers

oh yeah?!

nikomatsakis (Oct 24 2019 at 18:02, on Zulip):

awesome

nikomatsakis (Oct 24 2019 at 18:02, on Zulip):

I've been meaning to check on that

nikomatsakis (Oct 24 2019 at 18:02, on Zulip):

I'm wondering if we should go ahead and create that "ICEbreakers-bisection" team I was talking about

Santiago Pastorino (Oct 24 2019 at 18:02, on Zulip):

wow, quite some comments on that issue :)

yeah, people were trying to figure out how to make ci fail when there's a missing link like that one

nikomatsakis (Oct 24 2019 at 18:02, on Zulip):

maybe wait for a bit more progress on cargo bisect

Santiago Pastorino (Oct 24 2019 at 18:03, on Zulip):

would be nice to have merge priviledges on team

Santiago Pastorino (Oct 24 2019 at 18:03, on Zulip):

unsure who has

nikomatsakis (Oct 24 2019 at 18:03, on Zulip):

I guess I better approve some of those PRs

Santiago Pastorino (Oct 24 2019 at 18:03, on Zulip):

well maybe I do

nikomatsakis (Oct 24 2019 at 18:03, on Zulip):

yeah, I think it's only rust-lang/core?

nikomatsakis (Oct 24 2019 at 18:03, on Zulip):

not sure

Santiago Pastorino (Oct 24 2019 at 18:03, on Zulip):

ahh ok ok

Santiago Pastorino (Oct 24 2019 at 18:04, on Zulip):

yeah, in general there's not that much of stuff that I should be touching on team

Santiago Pastorino (Oct 24 2019 at 18:04, on Zulip):

but for the WGs that we are around

Santiago Pastorino (Oct 24 2019 at 18:04, on Zulip):

I mean, may be good idea to allow WG leaders or some people to merge stuff there

Santiago Pastorino (Oct 24 2019 at 18:04, on Zulip):

I won't merge people on core team, I promise :P

Santiago Pastorino (Oct 24 2019 at 18:05, on Zulip):

but seriously, I guess delegating as much as possible to people that do responsible things would be a good idea

Santiago Pastorino (Oct 24 2019 at 18:05, on Zulip):

and mainly if we are going for this kind of people auto sign up to WGs idea

Santiago Pastorino (Oct 24 2019 at 18:05, on Zulip):

there are a bunch unmerged on llvm-icebreakers :)

Santiago Pastorino (Oct 24 2019 at 18:06, on Zulip):

https://github.com/rust-lang/team/pull/161 https://github.com/rust-lang/team/pull/162 https://github.com/rust-lang/team/pull/163

nikomatsakis (Oct 24 2019 at 18:06, on Zulip):

yeah

nikomatsakis (Oct 24 2019 at 18:06, on Zulip):

so I just merged some

nikomatsakis (Oct 24 2019 at 18:06, on Zulip):

then I ran into conflicts

nikomatsakis (Oct 24 2019 at 18:06, on Zulip):

maybe I should just rebase them myself :)

Santiago Pastorino (Oct 24 2019 at 18:06, on Zulip):

I ended asking something silly which is alphabe ...

Santiago Pastorino (Oct 24 2019 at 18:06, on Zulip):

exactly :)

Santiago Pastorino (Oct 24 2019 at 18:06, on Zulip):

I think we may just close all the PRs and commit one with all of them :P

nikomatsakis (Oct 24 2019 at 18:07, on Zulip):

I guess we don't want to use the GitHub UI as it introduces merge commits

Santiago Pastorino (Oct 24 2019 at 18:07, on Zulip):

I ended asking something silly which is alphabe ...

I was asking hey please alphabetically sort yourself there, I kind of regretted about that, hehe

nikomatsakis (Oct 24 2019 at 18:07, on Zulip):

but it's too bad because it's kind of perfect

nikomatsakis (Oct 24 2019 at 18:08, on Zulip):

@Pietro Albini thoughts about that? (whether we care about using the Github web ui for editing commits on team; it creates merge commits)

Santiago Pastorino (Oct 24 2019 at 18:08, on Zulip):

yeah but I can open a branch and a PR with all of them

nikomatsakis (Oct 24 2019 at 18:08, on Zulip):

yeah ok

nikomatsakis (Oct 24 2019 at 18:08, on Zulip):

if you don't mind, sure

nikomatsakis (Oct 24 2019 at 18:08, on Zulip):

(ping me when you do and I will merge it)

Santiago Pastorino (Oct 24 2019 at 18:08, on Zulip):

rustc-guide has a thing I wasn't aware is that Github UI automatically squashes all the commits in a PR into just one

Santiago Pastorino (Oct 24 2019 at 18:08, on Zulip):

seem to match what happens on team

nikomatsakis (Oct 24 2019 at 18:09, on Zulip):

oh yeah there are options for that

nikomatsakis (Oct 24 2019 at 18:10, on Zulip):

e.g. I could click "squash and merge"

nikomatsakis (Oct 24 2019 at 18:10, on Zulip):

or "rebase and merge"

nikomatsakis (Oct 24 2019 at 18:10, on Zulip):

not sure what that does

nikomatsakis (Oct 24 2019 at 18:10, on Zulip):

I guess "squash and merge" is ok -- it doesn't create a merge commit

Santiago Pastorino (Oct 24 2019 at 18:10, on Zulip):

rebase and merge?

nikomatsakis (Oct 24 2019 at 18:10, on Zulip):

not 100% what I would want

Santiago Pastorino (Oct 24 2019 at 18:11, on Zulip):

rebase and merge?

that's interesting, unsure what it does

nikomatsakis (Oct 24 2019 at 18:11, on Zulip):

maybe I'll just squash and merge

nikomatsakis (Oct 24 2019 at 18:11, on Zulip):

seems fine

Santiago Pastorino (Oct 24 2019 at 18:11, on Zulip):

I think you want squash and merge in a repo like team

Santiago Pastorino (Oct 24 2019 at 18:11, on Zulip):

at least most of the time

Santiago Pastorino (Oct 24 2019 at 18:11, on Zulip):

or at least to signups like this

nikomatsakis (Oct 24 2019 at 18:11, on Zulip):

yeah seems fine

nikomatsakis (Oct 24 2019 at 18:11, on Zulip):

well once CI is green, will do

Santiago Pastorino (Oct 24 2019 at 18:12, on Zulip):

you don't want one commit for people adding themselves to team, then another to signup somewhere, then one for sorting, etc :P

Santiago Pastorino (Oct 24 2019 at 18:12, on Zulip):

after the meeting I can check out all these things and provide a PR with all of them

Santiago Pastorino (Oct 24 2019 at 18:12, on Zulip):

so we don't have conflicts

Santiago Pastorino (Oct 24 2019 at 18:13, on Zulip):

one thing that I wanted to mention that is somewhat related to this group

Santiago Pastorino (Oct 24 2019 at 18:13, on Zulip):

https://twitter.com/spastorino/status/1187415667420663808

Santiago Pastorino (Oct 24 2019 at 18:13, on Zulip):

I remember you told me that there are a lot of e-easy and e-mentor if e is the right prefix

Santiago Pastorino (Oct 24 2019 at 18:14, on Zulip):

more people than what I thought were going to answer actually ended answering

nikomatsakis (Oct 24 2019 at 18:14, on Zulip):

ah nice

Santiago Pastorino (Oct 24 2019 at 18:14, on Zulip):

some on twitter and some here private message on Zulip

nikomatsakis (Oct 24 2019 at 18:14, on Zulip):

that is the right prefix

nikomatsakis (Oct 24 2019 at 18:14, on Zulip):

not sure how many such issues there are :)

Santiago Pastorino (Oct 24 2019 at 18:14, on Zulip):

I think I can just create a thread for this, maybe on t-compiler/help ?

Santiago Pastorino (Oct 24 2019 at 18:15, on Zulip):

unsure where would fit, but, I could invite other members of the compiler team to hand tasks to "new" contributors

nikomatsakis (Oct 24 2019 at 18:16, on Zulip):

hmm

nikomatsakis (Oct 24 2019 at 18:16, on Zulip):

can't hurt :)

Santiago Pastorino (Oct 24 2019 at 18:16, on Zulip):

ok

nikomatsakis (Oct 24 2019 at 18:17, on Zulip):

so, what else is around for meta team today

Santiago Pastorino (Oct 24 2019 at 18:17, on Zulip):

hmmm, can we have a stream for that, maybe?

nikomatsakis (Oct 24 2019 at 18:17, on Zulip):

sort of a "help wanted" stream?

davidtwco (Oct 24 2019 at 18:17, on Zulip):

#new members could be used?

Santiago Pastorino (Oct 24 2019 at 18:17, on Zulip):

yeah, or ... something yeah

nikomatsakis (Oct 24 2019 at 18:17, on Zulip):

it's true that people often come to #new members looking for help

nikomatsakis (Oct 24 2019 at 18:17, on Zulip):

help finding things to do, that is

Santiago Pastorino (Oct 24 2019 at 18:18, on Zulip):

maybe a new topic there

nikomatsakis (Oct 24 2019 at 18:18, on Zulip):

I tend to think it should go the other way though

Santiago Pastorino (Oct 24 2019 at 18:18, on Zulip):

or maybe even t-compiler/new-contributors

Santiago Pastorino (Oct 24 2019 at 18:18, on Zulip):

unsure

nikomatsakis (Oct 24 2019 at 18:18, on Zulip):

which is why I like "help-wanted" a bit

Santiago Pastorino (Oct 24 2019 at 18:18, on Zulip):

anyway, don't want to distract too much because this is just somewhat related to the group

nikomatsakis (Oct 24 2019 at 18:18, on Zulip):

that is, it's always hard to "find work" for someone

nikomatsakis (Oct 24 2019 at 18:18, on Zulip):

but it's easier, when you see a task, to highlight it

Santiago Pastorino (Oct 24 2019 at 18:18, on Zulip):

agreed

Santiago Pastorino (Oct 24 2019 at 18:19, on Zulip):

t-compiler/help-wanted is what you meant then?

nikomatsakis (Oct 24 2019 at 18:19, on Zulip):

I guess in the end I think E-easy and E-mentor issues is also not terrible -- something I've found is that if you actually write instructions, people do tend to do them

Santiago Pastorino (Oct 24 2019 at 18:19, on Zulip):

or just in new members?

davidtwco (Oct 24 2019 at 18:19, on Zulip):

I do prefer the model of having a stream full of tasks for people to pick up, and they can comment when they have and use that topic to ask for help; rather than someone create a topic for themselves and then get pointed at an issue.

Santiago Pastorino (Oct 24 2019 at 18:19, on Zulip):

@davidtwco yeah that's my feeling too

Santiago Pastorino (Oct 24 2019 at 18:20, on Zulip):

ok t-compiler/help-wanted, I don't think I can create that so may bug you guys :)

davidtwco (Oct 24 2019 at 18:20, on Zulip):

No harm in trying it.

Santiago Pastorino (Oct 24 2019 at 18:20, on Zulip):

anyway, @nikomatsakis what do we have for this meeting that's not icebreakers

Santiago Pastorino (Oct 24 2019 at 18:20, on Zulip):

I guess we are done with that, right?

nikomatsakis (Oct 24 2019 at 18:20, on Zulip):

yep I thikn so

nikomatsakis (Oct 24 2019 at 18:21, on Zulip):

ok well there's many one step

nikomatsakis (Oct 24 2019 at 18:21, on Zulip):

do we want to advertise these ICE-breaker groups, e.g. on the rust-lang contributing page, etc?

Santiago Pastorino (Oct 24 2019 at 18:22, on Zulip):

yeah I think that won't hurt

Santiago Pastorino (Oct 24 2019 at 18:22, on Zulip):

well what do you mean by contributing page?

nikomatsakis (Oct 24 2019 at 18:22, on Zulip):

heh not sure

Santiago Pastorino (Oct 24 2019 at 18:22, on Zulip):

blog, rustc-guide section, compiler-team repo?

nikomatsakis (Oct 24 2019 at 18:22, on Zulip):

I don't know that the new website has one

Santiago Pastorino (Oct 24 2019 at 18:22, on Zulip):

internals?

Santiago Pastorino (Oct 24 2019 at 18:22, on Zulip):

:P

nikomatsakis (Oct 24 2019 at 18:22, on Zulip):

So I think https://rust-lang.github.io/compiler-team/ should at minimum have a link to the rustc-guide section

nikomatsakis (Oct 24 2019 at 18:23, on Zulip):

actually that page should really have a kind of "contributing" section in general

Santiago Pastorino (Oct 24 2019 at 18:23, on Zulip):

yep, agreed

nikomatsakis (Oct 24 2019 at 18:23, on Zulip):

it could also mention #t-compiler/help-wanted, if that existed :)

Santiago Pastorino (Oct 24 2019 at 18:23, on Zulip):

yes

nikomatsakis (Oct 24 2019 at 18:24, on Zulip):

I think it would just say

nikomatsakis (Oct 24 2019 at 18:24, on Zulip):

that said

nikomatsakis (Oct 24 2019 at 18:24, on Zulip):

we have some content like this in the rustc-guide, right?

Santiago Pastorino (Oct 24 2019 at 18:24, on Zulip):

one nice thing to do, to not be crazy about everything here in this meetings is creating an issue for that

Santiago Pastorino (Oct 24 2019 at 18:24, on Zulip):

:)

nikomatsakis (Oct 24 2019 at 18:24, on Zulip):

maybe we should just have a contributing section that redirects there

Santiago Pastorino (Oct 24 2019 at 18:24, on Zulip):

I can just start by creating an issue

nikomatsakis (Oct 24 2019 at 18:24, on Zulip):

I feel like the rustc-guide should be the canonical home for that sort of thing, as it can go into a lot more depth, and we have a lot of that content

nikomatsakis (Oct 24 2019 at 18:24, on Zulip):

only other thing on my mind is migrating procedures and things to forge

nikomatsakis (Oct 24 2019 at 18:25, on Zulip):

which isn't urgent but I think is a good idea

nikomatsakis (Oct 24 2019 at 18:25, on Zulip):

I can start by putting the compiler team contributors description there :)

Santiago Pastorino (Oct 24 2019 at 18:25, on Zulip):

yeah

nikomatsakis (Oct 24 2019 at 18:26, on Zulip):

enough for this week?

nikomatsakis (Oct 24 2019 at 18:26, on Zulip):

I'm still basking in the "hey we made the ICE-breakers thing happen" good feelings

nikomatsakis (Oct 24 2019 at 18:26, on Zulip):

now we just have to actually try and use it

Santiago Pastorino (Oct 24 2019 at 18:27, on Zulip):

enough yeah

Santiago Pastorino (Oct 24 2019 at 18:27, on Zulip):

with ICE-breakers in we should feel happy and have vacations for a while :joy:

nikomatsakis (Oct 24 2019 at 18:28, on Zulip):

:beach: :cocktail:

Santiago Pastorino (Oct 24 2019 at 18:30, on Zulip):

https://github.com/rust-lang/compiler-team/issues/208

Santiago Pastorino (Oct 24 2019 at 18:30, on Zulip):

one think meanwhile I was writing the issue that I realized is that, maybe we want both

Santiago Pastorino (Oct 24 2019 at 18:30, on Zulip):

a contributing section there and in rustc-guide (unsure if there's something there)

Santiago Pastorino (Oct 24 2019 at 18:30, on Zulip):

rustc-guide goes in deep into contributing

Santiago Pastorino (Oct 24 2019 at 18:31, on Zulip):

compiler-team is just a tiny text with a tiny thing

Santiago Pastorino (Oct 24 2019 at 18:31, on Zulip):

and have a more info that links to the rustc-guide contributing section

Santiago Pastorino (Oct 24 2019 at 18:35, on Zulip):

@nikomatsakis and also https://github.com/rust-lang/team/pull/169, so I can follow how notifications work and see what's going on there :)

Santiago Pastorino (Oct 25 2019 at 13:30, on Zulip):

@davidtwco @nikomatsakis has Zulip stopped from being advertized on rust-lang.org ?

Santiago Pastorino (Oct 25 2019 at 13:30, on Zulip):

couldn't find info here https://www.rust-lang.org/community but if I remember correctly there was something there

Santiago Pastorino (Oct 25 2019 at 13:30, on Zulip):

was just going to redirect a lot of people there

Santiago Pastorino (Oct 25 2019 at 13:30, on Zulip):

I was telling Niko that I got like 15 replies to my tweet, some over DM, some here and some public tweets

Santiago Pastorino (Oct 25 2019 at 13:31, on Zulip):

talking about https://twitter.com/spastorino/status/1187415667420663808

Last update: Nov 18 2019 at 00:40UTC