Stream: t-compiler/wg-rls-2.0

Topic: assist to expand star import


pachi (Jul 28 2020 at 14:45, on Zulip):

Is there any assist to convert form an star import (use crate::*) to specific items? IIRC it was implemented in RLS and it was great to work quickly and later remove the star uses.

Jonas Schievink (Jul 28 2020 at 14:45, on Zulip):

Not yet I believe

bjorn3 (Jul 28 2020 at 14:46, on Zulip):

I changed to topic name from "(no topic)". Hope you don't mind.

pachi (Jul 28 2020 at 14:47, on Zulip):

Oh, much better like that. I skimmed through the topics and couldn't figure out what to use...

pachi (Jul 28 2020 at 14:48, on Zulip):

Should I file a bug?

pachi (Jul 28 2020 at 14:48, on Zulip):

I couldn't find one at https://github.com/rust-analyzer/rust-analyzer/issues

Laurențiu Nicola (Jul 28 2020 at 14:49, on Zulip):

Sure

pachi (Jul 28 2020 at 14:52, on Zulip):

Done! https://github.com/rust-analyzer/rust-analyzer/issues/5557

Laurențiu Nicola (Jul 28 2020 at 14:53, on Zulip):

Can you include "glob" in the issue title for SEO purposes?

pachi (Jul 28 2020 at 14:54, on Zulip):

Indeed!

pachi (Jul 28 2020 at 14:55, on Zulip):

I've kept glob import (star import)

matthiaskrgr (Jul 28 2020 at 15:18, on Zulip):

There's a clippy lint that can do that https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

pachi (Jul 28 2020 at 15:46, on Zulip):

@matthiaskrgr Yes, the lint exists and warns about these imports. But, this is a request for an assist that can expand the glob with the items that are actually used in the module.

Last update: Sep 27 2020 at 14:45UTC