Stream: t-compiler/wg-rls-2.0

Topic: New highlighting glitches


Kirill Bulatov (Mar 30 2020 at 22:21, on Zulip):

Had stumbled onto a few glitches that I wanted to share yet not sure if it's worth to create a ticket for them (since the work on highlighting is still ongoing?)

I think we're missing type aliases' highlighting:
image.png

Since white colour appears to be the default, should we consider highlighting the attributes differently?

Also, it looks like the highlighting does not apply before any modification to a file: if I open the VSCode and just wait, nothing is highlighted before I start editing the file.

std::Veetaha (Mar 30 2020 at 23:04, on Zulip):

Yeah, I see the same type-and-only-then-it-updates glitches. But the problem with highlighting the type aliases and attributes is most likely that there is no color setup for these types of tokens.
I explicitly set the custom colors in my settings.json.
By the way, you can inspect the types of tokens via > Developer: Inspect Editor Tokens and Scopes:
image.png

Kirill Bulatov (Mar 31 2020 at 06:03, on Zulip):

Good to know that there's only one real glitch.
Yet I think it's good to add some defaults for those two entities.

Jeremy Kolb (Apr 02 2020 at 13:50, on Zulip):

It looks like insiders is now using the semantic tokens range request. It could be a source of bugs though a cursory glance suggests that it's working correctly.

Last update: Sep 30 2020 at 15:45UTC