Wouldn't that still build the
rust-analyzer crates in incremental mode if we removed it? Though I'm not sure what's being cached exactly.
I think @Christopher Durham can clarify on this probably?
The TL;DR is that we don't want to build incremental on CI
The cache for any builder is only populated the first time we build with that rustc/lockfile pair
And we're also explicitly removing the artifacts for local crates
Are we caching everything or just the dependencies? Ah, only deps, I looked up what
xtask pre-cache does. Yeah, I think it's fine to leave
CARGO_INCREMENTAL=0 in there.
Another important note is that _we don't update caches incrementally_, even if we didn't have the pre-cache step, due to the way GHA caching works