Stream: t-compiler/wg-rls-2.0

Topic: cicd

std::Veetaha (Apr 14 2020 at 09:57, on Zulip):

Is CARGO_INCREMENTAL=0 option still needed to be explicit in our ci config?
Doesn't this PR fix the build time issue?

Laurențiu Nicola (Apr 14 2020 at 10:11, on Zulip):

Wouldn't that still build the rust-analyzer crates in incremental mode if we removed it? Though I'm not sure what's being cached exactly.

std::Veetaha (Apr 14 2020 at 10:30, on Zulip):

I think @Christopher Durham can clarify on this probably?

Christopher Durham (Apr 14 2020 at 16:37, on Zulip):

The TL;DR is that we don't want to build incremental on CI

Christopher Durham (Apr 14 2020 at 16:39, on Zulip):

The cache for any builder is only populated the first time we build with that rustc/lockfile pair

Christopher Durham (Apr 14 2020 at 16:40, on Zulip):

And we're also explicitly removing the artifacts for local crates

Laurențiu Nicola (Apr 14 2020 at 16:42, on Zulip):

Are we caching everything or just the dependencies? Ah, only deps, I looked up what xtask pre-cache does. Yeah, I think it's fine to leave CARGO_INCREMENTAL=0 in there.

Christopher Durham (Apr 14 2020 at 18:32, on Zulip):

Another important note is that _we don't update caches incrementally_, even if we didn't have the pre-cache step, due to the way GHA caching works

Last update: Sep 22 2020 at 00:15UTC