Stream: t-compiler/wg-rls-2.0

Topic: Update the bin server?


Geobomatic (Feb 17 2020 at 13:53, on Zulip):

Hi there,
Since we have the marketplace extension that download the server, I was wondering how do we update it now? (Like, getting the weekly release build). I've looked for a command in the extension but couldn't find one.

matklad (Feb 17 2020 at 14:05, on Zulip):

In theory, the binary should just automatically update with today's releas

Laurențiu Nicola (Feb 17 2020 at 14:06, on Zulip):

By the way, when will the release be published to the Code marketplace?

matklad (Feb 17 2020 at 14:07, on Zulip):

when this CI job finishes: https://github.com/rust-analyzer/rust-analyzer/runs/450646393

Geobomatic (Feb 17 2020 at 14:08, on Zulip):

Ok, I'll wait for the maketplace release :slight_smile: thank you!

Laurențiu Nicola (Feb 17 2020 at 14:08, on Zulip):

Ah, I saw the tagged release on GitHub and thought it's ready

Laurențiu Nicola (Feb 17 2020 at 14:09, on Zulip):

It just failed

Laurențiu Nicola (Feb 17 2020 at 14:10, on Zulip):

ENOENT: no such file or directory, stat './dist/rust-analyzer-$EXT_VERSION.vsix'

Laurențiu Nicola (Feb 17 2020 at 14:11, on Zulip):

Should it say ${{ env.EXT_VERSION }} instead?

std::Veetaha (Feb 17 2020 at 14:11, on Zulip):

Just updating the extension in marketplace should work, you'll get a notification that proposes to download the new version of LSP server. @Geobomatic , if you won't see one, please notify!

matklad (Feb 17 2020 at 14:15, on Zulip):

Laurențiu Nicola: It just failed

third time's a charm they say:

pasted image

std::Veetaha (Feb 17 2020 at 14:16, on Zulip):

This is how deployment to production always looks like

matklad (Feb 17 2020 at 14:17, on Zulip):

Yeah, we need to implement CI for our CD

std::Veetaha (Feb 17 2020 at 14:18, on Zulip):

I am afraid this will result in infinite recursion...

std::Veetaha (Feb 17 2020 at 14:27, on Zulip):

pasted image

std::Veetaha (Feb 17 2020 at 14:30, on Zulip):

We need to rename the artifact here

Geobomatic (Feb 17 2020 at 14:54, on Zulip):

updated, and downloading the LSP fine, thank you guys!

std::Veetaha (Feb 17 2020 at 14:55, on Zulip):

Cool, thank you for the input too! Because my vscode crashed under WSL when the extension updated...

matklad (Feb 17 2020 at 14:55, on Zulip):

downloading the LSP fine, thank you guys!

@std::Veetaha you can breathe now, auto-update works, thanks for driving this!

Laurențiu Nicola (Feb 17 2020 at 20:27, on Zulip):

I know we don't really need an HTTP client in ra_lsp_server, but what if we made the server update itself? :-). Perhaps in the future we could um, remove the semicolons from the Code extension by removing lines of code

Laurențiu Nicola (Feb 24 2020 at 12:56, on Zulip):

@std::Veetaha I ran into "Failed to download language server from rust-analyzer GitHub repository: Cannot destructure property downloadUrl of 'undefined' or 'null'.", do you know if this is a known issue?

Laurențiu Nicola (Feb 24 2020 at 12:57, on Zulip):

I think I'm on e3037c2631ecb55996b676ce2c18b9df1858abaa, from Friday

Laurențiu Nicola (Feb 24 2020 at 12:58, on Zulip):

I think fetchArtifactReleaseInfo returns null as if it couldn't find the artifact

Laurențiu Nicola (Feb 24 2020 at 13:00, on Zulip):

then downloadServer calls downloadArtifact with null? I'm not sure how the postfix ! operator works

std::Veetaha (Feb 24 2020 at 13:03, on Zulip):

I knew an assert there would be needed @matklad )

std::Veetaha (Feb 24 2020 at 13:04, on Zulip):

Postfix ! operator just silences the compiler error (cast from nullable to non-nullable)

Laurențiu Nicola (Feb 24 2020 at 13:05, on Zulip):

Looks like it's a ra_lsp_server-linux vs. rust-analyzer-linux thing

Laurențiu Nicola (Feb 24 2020 at 13:05, on Zulip):

Yeah, it makes sense, the binary name has changed, but I'm trying to download the older release

Laurențiu Nicola (Feb 24 2020 at 13:08, on Zulip):

Downloading ra_lsp_server-linux: 5445.490ms

Laurențiu Nicola (Feb 24 2020 at 13:08, on Zulip):

So it was fast this time

Last update: May 29 2020 at 18:00UTC