Stream: t-compiler/wg-rls-2.0

Topic: Good issue for compiler newbie


Mikhail Rakhmanov (May 16 2020 at 12:55, on Zulip):

Hey! I really want to get into compilers and rust-analyzer in general as recently I started actively writing in Rust. What issue should I choose as my first one provided that I don't have a lot of experience in compilers? Should I take any with the label "Good first issue"? Or maybe you have something specific which would be better for a newcomer?

Laurențiu Nicola (May 16 2020 at 13:08, on Zulip):

Hi! Maybe also look over E-easy and E-has-instructions

Laurențiu Nicola (May 16 2020 at 13:09, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/issues/4468 might be approachable, too

Mikhail Rakhmanov (May 16 2020 at 14:05, on Zulip):

Laurențiu Nicola said:

https://github.com/rust-analyzer/rust-analyzer/issues/4468 might be approachable, too

Cool, thanks! Looking at IntelliJ implementation right now, just for reference leaving links to relevant PRs here (although not sure if it is helpful, still not very familiar with rust-analyzer, but will be looking into that) and the changelog where it was introduced (https://intellij-rust.github.io/2020/04/27/changelog-121.html).
By the way if I decide to work on something - should I mention that I started somewhere, or just create a PR as soon as it is done?

Laurențiu Nicola (May 16 2020 at 14:21, on Zulip):

You can leave a comment so that others won't start working on the same issue

Mikhail Rakhmanov (May 22 2020 at 20:36, on Zulip):

@Laurențiu Nicola Hi! It seems I implemented most of the functionality. Can you please look and suggest what can I improve? Thanks! https://github.com/rust-analyzer/rust-analyzer/pull/4576

Laurențiu Nicola (May 23 2020 at 08:36, on Zulip):

I only skimmed it, but there's a couple of unwrap()s that might end up crashing. We've had a lot of panics in assists in the past, partly because of the less-than-obvious thing that rust-analyzer tries to work with incomplete syntax trees (files with parse errors).

Mikhail Rakhmanov (May 23 2020 at 09:14, on Zulip):

Ok will check all unwraps and see if I can get rid of them

Mikhail Rakhmanov (May 23 2020 at 09:53, on Zulip):

Removed most of the unwraps

Mikhail Rakhmanov (May 24 2020 at 10:45, on Zulip):

Btw can you pls tell me what is left to finalize the PR? Thanks!

Laurențiu Nicola (May 24 2020 at 10:57, on Zulip):

I think it looks fine, but I'm not the best person to review it.

Chetan Khilosiya (Jul 07 2020 at 14:43, on Zulip):

Hi All, Can anyone please point me what is needed in this ticket https://github.com/rust-analyzer/rust-analyzer/issues/3813. I can help complete the ticket.

matklad (Jul 07 2020 at 14:44, on Zulip):

I think that actually should be fixed by https://github.com/rust-analyzer/rust-analyzer/pull/4615

matklad (Jul 07 2020 at 14:44, on Zulip):

it might be good to check if all looks good now, and close the issue then.

Chetan Khilosiya (Jul 07 2020 at 14:50, on Zulip):

Ok, I will look if that ticket is fixed.

Chetan Khilosiya (Jul 07 2020 at 16:48, on Zulip):

I verified that the issue is fixed properly. rust-hover-fix.png

matklad (Jul 07 2020 at 16:49, on Zulip):

Thanks @Chetan Khilosiya !

Chetan Khilosiya (Jul 07 2020 at 16:49, on Zulip):

The hover popup respects font size either.
Tested on latest master branch. And updated the ticket also.

Last update: Sep 22 2020 at 00:15UTC