Stream: t-compiler/wg-rls-2.0

Topic: [solved] rust-analyzer: snap update?


Laurențiu Nicola (Apr 08 2019 at 13:51, on Zulip):

I'm getting a lot of failed tests because of trailing commas in the snapshots, did anyone else notice that?

Laurențiu Nicola (Apr 08 2019 at 13:51, on Zulip):

e.g.

Snapshot file: crates/ra_ide_api/src/snapshots/tests__highlighting.snap
Snapshot: highlighting
Source: crates/ra_ide_api/src/syntax_highlighting.rs:79
Old: Sat, 23 Mar 2019 18:20:31 +0200
New: Mon,  8 Apr 2019 16:49:40 +0300

-old snapshot
+new results
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
result
──────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
    1 │ Ok(
    2 │     [
    3 │         HighlightedRange {
    4 │             range: [1; 11),
    5 │-            tag: "comment"
    6 │+            tag: "comment",
    7 │         },
    8 │         HighlightedRange {
    9 │             range: [12; 14),
   10 │-            tag: "keyword"
   11 │+            tag: "keyword",
   12 │         },
   13 │         HighlightedRange {
   14 │             range: [15; 19),
   15 │-            tag: "function"
   16 │+            tag: "function",
   17 │         },
   18 │         HighlightedRange {
   19 │             range: [29; 37),
   20 │-            tag: "macro"
   21 │+            tag: "macro",
   22 │         },
   23 │         HighlightedRange {
   24 │             range: [38; 50),
   25 │-            tag: "string"
   26 │+            tag: "string",
   27 │         },
   28 │         HighlightedRange {
   29 │             range: [52; 54),
   30 │-            tag: "literal"
   31 │-        }
   32 │-    ]
   33 │+            tag: "literal",
   34 │+        },
   35 │+    ],
   36 │ )
Florian Diebold (Apr 08 2019 at 13:52, on Zulip):

I guess there's no guarantees for the Debug format, so it may depend on the rust version...

Laurențiu Nicola (Apr 08 2019 at 13:53, on Zulip):

hm, good point

Laurențiu Nicola (Apr 08 2019 at 13:54, on Zulip):

filed a tiny PR, let's see if Travis is happy

Laurențiu Nicola (Apr 08 2019 at 13:58, on Zulip):

yeah, never mind, it's all right

Capitalism (Apr 09 2019 at 19:34, on Zulip):

Nightly was just updated to add trailing commas on all elements in structs. Was merged 1-2 days ago.

Last update: Nov 19 2019 at 19:05UTC