Stream: t-compiler/wg-rls-2.0

Topic: Reviews


Paul Faria (Jun 11 2020 at 13:51, on Zulip):

Good morning @matklad ! I was curious if there's anything else I need to do for https://github.com/rust-analyzer/rust-analyzer/pull/4587 or https://github.com/rust-analyzer/rust-analyzer/pull/4743. I wasn't sure how often I should try to rebase to keep it up to date in case that's messing up the reviews (losing comment context). I also didn't want to pester anyone by hitting the request review every few days. For this project at least, how often should I ping for an update?

Paul Faria (Jun 11 2020 at 13:52, on Zulip):

I'm also in no rush here. They're simple and small enough to maintain for a while

matklad (Jun 11 2020 at 13:53, on Zulip):

Yeah, I didn't have a chance to review those properly yet (have been busy with rewriting the VFS)

Paul Faria (Jun 11 2020 at 13:54, on Zulip):

No worries, I'll circle back in a while then. Any issue with rebasing when conflicts come up?

matklad (Jun 11 2020 at 13:56, on Zulip):

No, we actually prefer rebase approach

Paul Faria (Jun 11 2020 at 13:57, on Zulip):

Ok, sounds good. Thanks for the quick respone!

Last update: Sep 27 2020 at 12:45UTC