Stream: t-compiler/wg-rls-2.0

Topic: #1331

Edwin Cheng (May 28 2019 at 10:49, on Zulip):

Anyone can confirm that rust-analyzer/rust-analyzer#1331 is fixed after rust-analyzer/rust-analyzer#1334 landed in current master(0545e47)? In my machine it is worse then before. It seem to in a loop of panic rewinding.

matklad (May 28 2019 at 10:55, on Zulip):

Hm, it's much better for me now

matklad (May 28 2019 at 10:56, on Zulip):

Can you run the test, added in that PR and check that commenting db.check_canceled() fails the tests?

matklad (May 28 2019 at 10:56, on Zulip):

certain amount of cancellation and unwinding is expected

matklad (May 28 2019 at 10:57, on Zulip):

I'd even say, most of diagnostics should end up being canceled, because use types most of the time

Last update: Sep 18 2020 at 21:00UTC