Stream: t-compiler/wg-rls-2.0

Topic: ra_vfs and text ranges


Laurențiu Nicola (Apr 25 2020 at 17:51, on Zulip):

@matklad how would you feel about https://github.com/rust-analyzer/ra_vfs/blob/bdecce9c6b753b825e040130efe25b1fe1674f85/src/lib.rs#L253 getting a Vec<TextRange> or similar? Or would you rather it only got a string like now?

matklad (Apr 25 2020 at 18:09, on Zulip):

For incremental changeds? I feel it should rather be Fn(&mut String)

std::Veetaha (Apr 25 2020 at 18:18, on Zulip):

What does overlay mean in this case?

Laurențiu Nicola (Apr 25 2020 at 18:24, on Zulip):

I think it's a combination of the on-disk file contents and the in-memory changes from the editor.

Laurențiu Nicola (Apr 25 2020 at 18:32, on Zulip):

matklad said:

For incremental changeds? I feel it should rather be Fn(&mut String)

That makes sense, thanks

Last update: May 29 2020 at 17:20UTC