Stream: t-compiler/wg-rls-2.0

Topic: server_sync_issue


std::Veetaha (Feb 16 2020 at 15:49, on Zulip):

@matklad , may I ask you to describe what was the issue you fixed in this PR?
https://github.com/rust-analyzer/rust-analyzer/pull/2709

std::Veetaha (Feb 16 2020 at 15:50, on Zulip):

This comment in particular: https://github.com/rust-analyzer/rust-analyzer/pull/2709/files#diff-0099aced0b5826ac85b37c58f68dcf96R14-R17

matklad (Feb 16 2020 at 15:50, on Zulip):

The PR was a general refactoing, only the last PR fixes the problem introduced by it

matklad (Feb 16 2020 at 15:50, on Zulip):

Basically, both langauge server and type hints register "onChange" handlers

matklad (Feb 16 2020 at 15:50, on Zulip):

And type hints call back into the server

matklad (Feb 16 2020 at 15:51, on Zulip):

So, if typehints handler get's registered first, it'll call into the server which hasn't received the last update yet.

Last update: May 29 2020 at 17:15UTC