Stream: t-compiler/wg-rls-2.0

Topic: Binary is renamed in master


matklad (Feb 18 2020 at 12:31, on Zulip):

Headsup, the ra_lsp_server binary is renamed to rust-analyzer in the master branch

std::Veetaha (Feb 18 2020 at 12:48, on Zulip):

ra_lsp_server was fine...

Jeremy Kolb (Feb 18 2020 at 12:50, on Zulip):

@std::Veetaha it now does ra_cli things so the new name is more appropriate

Jeremy Kolb (Feb 18 2020 at 12:50, on Zulip):

it's not a big deal :)

std::Veetaha (Feb 18 2020 at 12:53, on Zulip):

I'll miss old times...

std::Veetaha (Feb 18 2020 at 12:54, on Zulip):

RIP ra_lsp_server

Laurențiu Nicola (Feb 18 2020 at 14:10, on Zulip):

(deleted)

Florian Diebold (Feb 18 2020 at 14:31, on Zulip):

this will also break @Edwin Cheng 's analysis stats page :disappointed:

std::Veetaha (Feb 18 2020 at 14:34, on Zulip):

What is that page?

Edwin Cheng (Feb 18 2020 at 14:40, on Zulip):

I just fixed it two times today :joy:

Edwin Cheng (Feb 18 2020 at 14:44, on Zulip):

@std::Veetaha https://edwin0cheng.github.io/github-action-usage-test/

Edwin Cheng (Feb 18 2020 at 14:46, on Zulip):

And I agreed the new name is more appropriate too.

Florian Diebold (Feb 18 2020 at 14:47, on Zulip):

(btw, that page is getting a bit slow, I want to implement some kind of pagination for it some time :sweat_smile: )

Edwin Cheng (Feb 18 2020 at 14:50, on Zulip):

:ok:🏻 Let’s me implement it in this weekend.

Laurențiu Nicola (Feb 18 2020 at 14:55, on Zulip):

Um, are those commit numbers under the graph useful?

Kirill Bulatov (Feb 18 2020 at 14:56, on Zulip):

Would be great to explicitly mention somewhere that

Kirill Bulatov (Feb 18 2020 at 14:57, on Zulip):

Hm, should we also rename the raLspServerPath? :thinking:

Laurențiu Nicola (Feb 18 2020 at 14:57, on Zulip):

It's already renamed

Kirill Bulatov (Feb 18 2020 at 14:58, on Zulip):

Ah, thanks.

Laurențiu Nicola (Feb 18 2020 at 14:58, on Zulip):

rust-analyzer.serverPath

Laurențiu Nicola (Feb 18 2020 at 14:59, on Zulip):

pasted image Am I holding it wrong?

detrumi (Feb 18 2020 at 15:00, on Zulip):

Looks the same for me

Florian Diebold (Feb 18 2020 at 15:01, on Zulip):

there used to be less of them ;)

Edwin Cheng (Feb 18 2020 at 15:02, on Zulip):

Thats why it need pagination :joy:

Laurențiu Nicola (Feb 18 2020 at 15:05, on Zulip):

Nah, it's fine without the labels

std::Veetaha (Feb 18 2020 at 15:09, on Zulip):

@Kirill Bulatov Don't worry, this won't affect the VSCode release download in any way, our code is resistant to that

std::Veetaha (Feb 18 2020 at 15:11, on Zulip):

Though, yeah, we will leave an unused ra_lsp_server[-os][.exe] binary at users filesystem...

Laurențiu Nicola (Feb 18 2020 at 15:14, on Zulip):

std::Veetaha said:

Kirill Bulatov Don't worry, this won't affect the VSCode release download in any way, our code is resistant to that

That's because prebuiltServerFileName() was updated in the same PR, right?

std::Veetaha (Feb 18 2020 at 15:14, on Zulip):

Right, this was the single source of truth

std::Veetaha (Feb 18 2020 at 15:15, on Zulip):

I guess we may save binaries under different name on users PC, so that we don't leave grabage when we rename stuff, but nah...)

matthiaskrgr (Feb 18 2020 at 16:01, on Zulip):

I'm getting

Failed to download language server from rust-analyzer GitHub repository: Cannot destructure property `downloadUrl` of 'undefined' or 'null'.

perhaps that is related?

matklad (Feb 18 2020 at 16:03, on Zulip):

Yes, it is realted. The new extension only works at the moment if you build the server from source, and set rust-analyzer.serverPath config to rust-analyzer

matthiaskrgr (Feb 18 2020 at 16:05, on Zulip):

it worked, thanks! :+1:

std::Veetaha (Feb 18 2020 at 16:10, on Zulip):

@matklad , this is why I put an assert there initally, I knew we would have this problem....

Edwin Cheng (Feb 23 2020 at 05:13, on Zulip):

@Florian Diebold pagination is added :)

Florian Diebold (Feb 23 2020 at 09:40, on Zulip):

Great :tada: loads much faster :)

Kirill Bulatov (Feb 23 2020 at 10:19, on Zulip):

Neat, way better.

Although current picture is too good to be true, isn't it? :)
Would it make sense to add projects that heavily depend on macros?
tokio, nalgebra or something that uses them?

Edwin Cheng (Feb 23 2020 at 10:46, on Zulip):

All these project are coming from rustc-perf and I just link it by submodule and whitelist some of them.

Kirill Bulatov (Feb 23 2020 at 10:48, on Zulip):

Ah, interesting.
Well, maybe some other time then.

Edwin Cheng (Feb 23 2020 at 11:20, on Zulip):

I think it is a good idea to test on these crates, let me find a way to include more crates without much effort.

Last update: Sep 30 2020 at 14:30UTC