Stream: t-compiler/wg-rls-2.0

Topic: Doc comments highlighting


std::Veetaha (Jun 15 2020 at 14:14, on Zulip):

As for me it looks like we lack semantic tokens for punctuation and macros, am I right?

image.png

matklad (Jun 15 2020 at 14:19, on Zulip):

I thnk so, yeh

Paul Faria (Jun 18 2020 at 12:52, on Zulip):

Regarding https://github.com/rust-analyzer/rust-analyzer/pull/4903#issuecomment-645442415 any thoughts on how to handle the one case I brought up (comments in doc comments are indistinguishable from doc comments if we append documentation to all items in a doctest)? I wanted to explore possible options here.

Paul Faria (Jun 18 2020 at 12:53, on Zulip):

My preference would be to mark them with a doctest modifier instead, but I'm also open to any other ideas. My personal preference is to have the two comments show differently if the code is also going to be highlighted differently.

matklad (Jun 18 2020 at 12:58, on Zulip):

Yeah, I think a separate modifier makes sense. Instead of documentation, we should use something that means "this code is highlihgitng as rust, but is really a comment". Not sure about the right name

matklad (Jun 18 2020 at 12:58, on Zulip):

maybe just "injected"?

Paul Faria (Jun 18 2020 at 13:02, on Zulip):

ok, in that case do you think it makes sense to pull this out, then in a new story do this along with the other item we mentioned? The one about adding the new modifier to the operators and currently unmarked items like = ;, etc. (Not sure if something else might get missed).

Paul Faria (Jun 18 2020 at 13:04, on Zulip):

I could go either way there

matklad (Jun 18 2020 at 13:05, on Zulip):

Splitting PRs is always a good idea!

Paul Faria (Jun 18 2020 at 13:09, on Zulip):

ok, will do, then we can bikeshed the modifier in a whole new story :D

Paul Faria (Jun 18 2020 at 13:14, on Zulip):

Just pushed an update for the PR (should be good to go at this point) and created https://github.com/rust-analyzer/rust-analyzer/issues/4939 to track the new modifier. I'll get started on that right away (I think it should also be entirely independent of the documentation highlighting)

Paul Faria (Jun 18 2020 at 13:39, on Zulip):

Ok, new PR is up with the fixes: https://github.com/rust-analyzer/rust-analyzer/pull/4940

Last update: Sep 27 2020 at 14:15UTC