Stream: t-compiler/wg-rls-2.0

Topic: About watchman


Muhammad Mominul Huque (Dec 27 2019 at 19:09, on Zulip):

@matklad
Hi! As far as I can remember, you had mentioned using watchman instead of notify which is a cause for a bug in macOS. It seems there's a rust binding available of the client library. Should we use it? Or you have other approach?
Sorry for the noise!

matklad (Dec 27 2019 at 19:27, on Zulip):

Thanks a bunch for that link! Looks like the author of that library is the
person who made watchman itself, we should definitely use this!

bjorn3 (Dec 27 2019 at 19:29, on Zulip):

Yes, in fact it's source can be found in the watchman repo: https://github.com/facebook/watchman/tree/master/rust

Muhammad Mominul Huque (Dec 27 2019 at 21:39, on Zulip):

I'd want to try implementing this if there's no hurry. :grinning_face_with_smiling_eyes:
This crate uses async-await, so we'd need to use tokio. I am new within this async world and haven't touched the file watching part of rust-analyser yet, so I might need mentoring!

From a quick look, It seems we might only need to have changes in ra_vfs?

matklad (Dec 28 2019 at 10:52, on Zulip):

I actually think that we need to redo api of vfs to better match
watchman’s. It seems like watchman figured out better abstractions

Muhammad Mominul Huque (Dec 28 2019 at 20:10, on Zulip):

Hmm, it looks like it would be quite complex for me to do. I think we should open an issue so we don't forget and others can collaborate.

Last update: Sep 18 2020 at 21:15UTC