We might want to have some PR labels like
rustc has (
S-inactive). We have 21 open PRs now -- that's quite higher than what we used to.
TBH, I am pretty anti-label myself
Welp, okay :-)
Like, I don't find labels useful for me. I do find
E- labels useful for contributors, that's why I use them
Isn't it hard to keep track of those that still need to be reviewed?
It is, but it's because there are more PRs that I can comfortably review, not because they are unlabled.
Fair enough. It might end up a moot point anyway when the repo is moved to the rust-lang org.
it'll still be a separate repo though
I hope so :D
TBH, I feel like there might be a blind spot for me? I sincerely don't understand why so many projects use so many different labels :)
If other contributors find labels useful, than we can add them!
Though, as usual, I think that it's more likely that the world is insane rather than me :) So I'll need a pretty strong arguments from other team members to convince me that yes, labels really help them :)
A-ty labels useful to see the type system bugs, that's why I'm adding them :sweat_smile: for PRs, I think in the current state maintaining the labels would be more work than it saves
yeah, it's also true that y'all can just silently add labels, and i won't notice :D
A-macro labels is very useful for me to find what bugs I have to fix :) and that's it.
Ok, every contributor is allowed to have one favorite label /s :D
OTOH, the problem of github
Assignees is that it might prevent new contributors to submit PR for that issue.
What did I start? :-(
Honestly, regarding labels, at work we have a "Need changes" label which is very useful to quickly find PRs that you don't need to review at the moment. But I guess it doesn't work if contributors can't remove it themselves
Yeah, the onus would be on the triagers to update the labels