Stream: t-compiler/wg-rls-2.0

Topic: PR labels


Laurențiu Nicola (Apr 28 2020 at 15:10, on Zulip):

We might want to have some PR labels like rustc has (S-waiting-on-review, S-waiting-on-author, S-inactive). We have 21 open PRs now -- that's quite higher than what we used to.

matklad (Apr 28 2020 at 15:11, on Zulip):

TBH, I am pretty anti-label myself

Laurențiu Nicola (Apr 28 2020 at 15:11, on Zulip):

Welp, okay :-)

matklad (Apr 28 2020 at 15:12, on Zulip):

Like, I don't find labels useful for me. I do find E- labels useful for contributors, that's why I use them

Laurențiu Nicola (Apr 28 2020 at 15:12, on Zulip):

Isn't it hard to keep track of those that still need to be reviewed?

matklad (Apr 28 2020 at 15:15, on Zulip):

It is, but it's because there are more PRs that I can comfortably review, not because they are unlabled.

Laurențiu Nicola (Apr 28 2020 at 15:17, on Zulip):

Fair enough. It might end up a moot point anyway when the repo is moved to the rust-lang org.

matklad (Apr 28 2020 at 15:22, on Zulip):

it'll still be a separate repo though

Laurențiu Nicola (Apr 28 2020 at 15:23, on Zulip):

I hope so :D

matklad (Apr 28 2020 at 15:25, on Zulip):

TBH, I feel like there might be a blind spot for me? I sincerely don't understand why so many projects use so many different labels :)

If other contributors find labels useful, than we can add them!

Though, as usual, I think that it's more likely that the world is insane rather than me :) So I'll need a pretty strong arguments from other team members to convince me that yes, labels really help them :)

Florian Diebold (Apr 28 2020 at 15:35, on Zulip):

I find A-ty labels useful to see the type system bugs, that's why I'm adding them :sweat_smile: for PRs, I think in the current state maintaining the labels would be more work than it saves

matklad (Apr 28 2020 at 15:36, on Zulip):

yeah, it's also true that y'all can just silently add labels, and i won't notice :D

Edwin Cheng (Apr 28 2020 at 17:20, on Zulip):

A-macro labels is very useful for me to find what bugs I have to fix :) and that's it.

matklad (Apr 28 2020 at 17:20, on Zulip):

Ok, every contributor is allowed to have one favorite label /s :D

bjorn3 (Apr 28 2020 at 17:23, on Zulip):

A-the-label-that-every-issue-and-pr-must-have-to-make-matklad-happy :smile:

Edwin Cheng (Apr 28 2020 at 17:24, on Zulip):

OTOH, the problem of github Assignees is that it might prevent new contributors to submit PR for that issue.

Laurențiu Nicola (Apr 28 2020 at 17:24, on Zulip):

bjorn3 said:

A-the-label-that-every-issue-and-pr-must-have-to-make-matklad-happy :smile:

What did I start? :-(

Bastien Orivel (Apr 28 2020 at 17:35, on Zulip):

Honestly, regarding labels, at work we have a "Need changes" label which is very useful to quickly find PRs that you don't need to review at the moment. But I guess it doesn't work if contributors can't remove it themselves

Laurențiu Nicola (Apr 28 2020 at 17:36, on Zulip):

Yeah, the onus would be on the triagers to update the labels

Last update: May 29 2020 at 15:30UTC