Stream: t-compiler/wg-rls-2.0

Topic: Snapshots ignored?


Paul Faria (Jun 27 2020 at 15:45, on Zulip):

@matklad I noticed that a change to a highlighting snapshots somehow caused the entire file to be removed, but there was no missing file indicator. I noticed that *.html was recently added to .gitignore. Was it intended to ignore the snapshots, or are they being accidentally ignored?

matklad (Jun 27 2020 at 15:52, on Zulip):

nope, that's a mistake, we should remove .html from gitignore

Paul Faria (Jun 27 2020 at 15:56, on Zulip):

want me to do it with the missing unsafe validation PR? Or separately?

matklad (Jun 27 2020 at 16:01, on Zulip):

I've already r+ed the PR, so you'll need a new oen

Paul Faria (Jun 27 2020 at 16:02, on Zulip):

Ok, no worries. Will do

matklad (Jun 27 2020 at 16:02, on Zulip):

wait, just push a new comment, i'll d+

Paul Faria (Jun 27 2020 at 16:02, on Zulip):

ok

Paul Faria (Jun 27 2020 at 16:02, on Zulip):

done

Paul Faria (Jun 27 2020 at 16:03, on Zulip):

ok, just r+'ed bors

Laurențiu Nicola (Jun 27 2020 at 16:38, on Zulip):

We can close rust-analyzer#190, right?

Jonas Schievink (Jun 27 2020 at 16:42, on Zulip):

it's still missing https://github.com/rust-analyzer/rust-analyzer/pull/4743

Laurențiu Nicola (Jun 27 2020 at 16:43, on Zulip):

Ah, right

Paul Faria (Jun 27 2020 at 16:57, on Zulip):

Working on it :)

Last update: Sep 27 2020 at 13:15UTC