Stream: t-compiler/wg-rls-2.0

Topic: publishing


pksunkara (Apr 22 2020 at 19:31, on Zulip):

What's the reason for not publishing the ra_* crates on crates.io?

matklad (Apr 22 2020 at 21:04, on Zulip):

It's work

pksunkara (Apr 22 2020 at 22:29, on Zulip):

Is it because it's a workspace and therefore not enough automation? Or is it versioning concerns?

matklad (Apr 22 2020 at 22:31, on Zulip):

The main work is that, if we publish things, someone needs to make decsisions about when to publish, what versioning scheme to use, etc

pksunkara (Apr 22 2020 at 22:47, on Zulip):

Since we don't consider it stable, can't we publish a minor version every monday? For example, 0.2.0 this monday, 0.3.0 next monday, like that until we make the decision to make it stable

pksunkara (Aug 12 2020 at 00:34, on Zulip):

@Laurențiu Nicola Can you please set this to Draft PR? https://github.com/rust-analyzer/rust-analyzer/pull/5713. I messed up when creating it

Laurențiu Nicola (Aug 12 2020 at 04:54, on Zulip):

@pksunkara I don't have the rights to do so, but you should be able to. Is there a link on the right side, under the reviewers section? It says "convert to draft". That's where it is in the new GitHub UI, at least.

pksunkara (Aug 13 2020 at 00:29, on Zulip):

@matklad Great work on the renames. :+1:

pksunkara (Aug 13 2020 at 00:59, on Zulip):

I sent 2 renaming PRs which should not have any conflicts. https://github.com/rust-analyzer/rust-analyzer/pull/5734 and https://github.com/rust-analyzer/rust-analyzer/pull/5735

matklad (Aug 13 2020 at 16:31, on Zulip):

Renamed all crates & set the version to 0.0.0

pksunkara (Aug 24 2020 at 10:55, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/pull/4776#issuecomment-679040531, I can put the description as TBD for now

pksunkara (Aug 24 2020 at 10:55, on Zulip):

But I just wanted to confirm with you before doing it

matklad (Aug 24 2020 at 10:58, on Zulip):

Yeah, if we have to put the descriptions, let's put somethign

pksunkara (Aug 24 2020 at 11:03, on Zulip):

Okay, will do

pksunkara (Aug 24 2020 at 11:08, on Zulip):

Done. The PR is now ready. Please don't forget to add the CARGO_REGISTRY_TOKEN secret

matklad (Aug 24 2020 at 11:10, on Zulip):

Token added!

pksunkara (Aug 24 2020 at 12:09, on Zulip):

Waiting for you to trigger another publish run :innocent:

pksunkara (Aug 24 2020 at 13:12, on Zulip):

Auto publishing successfully finished. Thanks for the patience. Just ping me here if anything goes wrong.

NOTE: These are the triggers for publishing. Please double check.

matklad (Aug 24 2020 at 13:14, on Zulip):

tbh, I don't have a good feeling for what the trigger should be. Current one looks fine. We might just re-use the one from nightly/release as well.

pksunkara (Aug 24 2020 at 14:31, on Zulip):

So, I need this load_cargo function but we haven't published rust-analyzer. I am honestly not sure what to do here. Should I just publish ra_ap_rust-analyzer or try to extract this code to a different crate?

matklad (Aug 24 2020 at 14:33, on Zulip):

I think publishing ra_ap_ra is the simplest here

pksunkara (Aug 24 2020 at 15:24, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/pull/5859

pksunkara (Aug 25 2020 at 09:40, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/pull/5865

pksunkara (Aug 25 2020 at 12:30, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/pull/5873

pksunkara (Aug 25 2020 at 13:50, on Zulip):

Published successfully. cargo install ra_ap_rust-analyzer should work

matklad (Aug 25 2020 at 13:52, on Zulip):

:tada:

pksunkara (Aug 29 2020 at 10:52, on Zulip):

@matklad Just wanted to say thanks for helping me publish the crates. I have successfully built a prototype for analysis tools based on rust-analyzer. https://github.com/pksunkara/cargo-up. It has a visitor defined https://github.com/pksunkara/cargo-up/blob/master/cargo-up/src/lib/visitor.rs which other tools can copy or use directly. An example of how this tool can be used to upgrade code in clap is https://github.com/clap-rs/clap/blob/master/clap_up/src/lib.rs. Would love your opinion

Jeremy Kolb (Aug 31 2020 at 12:04, on Zulip):

oh that's cool!

matklad (Aug 31 2020 at 14:35, on Zulip):

@pksunkara took a peek, looks resonable.

I'd love to see SSR capabilities enhanced to enable these kinds of transformations declaratively, but i am unsure what that API should look like

pksunkara (Aug 31 2020 at 15:21, on Zulip):

Yeah, that would be a good start. But I'm unsure if SSR (even with enhancements) would be capable of doing more complex stuff

matklad (Aug 31 2020 at 15:22, on Zulip):

Well, we might try to nerd-snipe @David Lattimore :D

pksunkara (Aug 31 2020 at 15:23, on Zulip):

Thanks @Jeremy Kolb . It still needs a lot of work but my hope is that we can use this to automatically move code to 2021 edition when it happens

bjorn3 (Aug 31 2020 at 16:07, on Zulip):

For the 2018 edition there were a bunch of lints in the compiler that made code compatible with both 2015 and 2018 at the same time. cargo fix could then automatically apply the suggestions.

Last update: Sep 22 2020 at 02:15UTC