Stream: t-compiler/wg-rls-2.0

Topic: Snippets broken


Jonas Schievink (May 24 2020 at 21:52, on Zulip):

Since a couple of days I keep getting weirdly formatted functions after applying "add missing impl members":

    fntcx< 'a>(& 'aself)->TyCtxt< 'tcx> {
        todo!()
    }

Is that a known bug? I would have expected the tests to catch this, so maybe it's a local issue? Has someone seen this before?

matklad (May 24 2020 at 21:57, on Zulip):

You might want to rebuild vscode extension from master, we‘ve changed our
approach to snippets, and there were couple of regressions, which were
fixed (unless this is a regression introduced by the said fixes) mp

Jonas Schievink (May 24 2020 at 22:03, on Zulip):

Hmm, same behavior on master

matklad (May 25 2020 at 07:18, on Zulip):

Yeah, tried this today, can't reproduce... This seems like something is wrong on the client side, and it is handled here now:

https://github.com/rust-analyzer/rust-analyzer/blob/fbb8b884a2dbc3ced720c84f4604466e223f6d69/editors/code/src/commands/index.ts#L67-L90

Although, I must say I cannot fathom what might cause us to misplace whitespace .....

Last update: Sep 27 2020 at 14:45UTC