Stream: t-compiler/wg-rls-2.0

Topic: merged vscode settings

Igor Matuszewski (May 07 2020 at 18:38, on Zulip):

@matklad so I've been wanting to redesign the settings keys in the extension and was wondering what might be a good approach since we'd introduce a new swath of settings for rust-analyzer.

I've had a look at how other extensions do it and the approach I liked best was C#'s - e.g. it used tool-specific prefix without a common extension-wide prefix so omnisharp.{path, autoStart, ...} for OmniSharp-specific settings, razor.{...} for Razor-specific ones and csharp.{...} for regular/top-level settings.

This renders quite nicely in the new graphical UI for vscode settings and it' still discoverable by navigating to Extensions > C# > Feature Contributions where there's an entire list of them - obviously that's the same for 'C# configuration' section in the graphical UI for vscode settings.

What do you think?

Igor Matuszewski (May 07 2020 at 18:39, on Zulip):

I believe this has the benefit of retaining the 'rust-analyzer.{...}' settings already used by the RA extension

matklad (May 07 2020 at 18:42, on Zulip):

Hm, I think, in the end, I'd prefer to namespace just everything under rust

matklad (May 07 2020 at 18:43, on Zulip):

It's better for json completion, where you can do rust.

matklad (May 07 2020 at 18:43, on Zulip):

But using several different keys doesn't seem to bad to me either.

Jeremy Kolb (May 07 2020 at 20:11, on Zulip):

Isn't there already a language. convention for vscode?

Laurențiu Nicola (May 08 2020 at 06:49, on Zulip):

I'm strongly in favor of a rust. prefix, even if only for discoverability.

Igor Matuszewski (May 11 2020 at 13:47, on Zulip):

Jeremy Kolb said:

Isn't there already a language. convention for vscode?

The above settings such as razor. prefixed one come from official Microsoft's C# extension so I assume it depends on the team

Igor Matuszewski (May 11 2020 at 13:48, on Zulip):

there is also the [$langId]: { <settings_for_any_$langId_file> } which applies for anything activated for a specific language

Last update: Sep 22 2020 at 02:15UTC