Stream: t-compiler/wg-rls-2.0

Topic: nightly builds of salsa


nikomatsakis (Mar 13 2019 at 19:41, on Zulip):

Hey @matklad or others --

Are you able to build the rust-analyzer with the currently nightly?

After upgrading chalk to use salsa 0.10.0, I get errors like this with nightly:

Indexing chalk-solve
   Compiling salsa-macros v0.10.0
   Compiling lalrpop v0.16.0
   Compiling failure v0.1.5
error[E0412]: cannot find type `Result` in module `syn`
   --> /home/nmatsakis/.cargo/registry/src/github.com-1ecc6299db9ec823/salsa-macros-0.10.0/src/database_storage.rs:190:42
    |
190 |     fn parse(input: ParseStream) -> syn::Result<Self> {
    |                                          ^^^^^^ not found in `syn`
help: possible candidates are found in other modules, you can import them into scope
    |
1   | use core::fmt::Result;
    |
1   | use core::prelude::v1::Result;
    |
1   | use core::result::Result;
    |
1   | use std::fmt::Result;
    |
and 6 other candidates
nikomatsakis (Mar 13 2019 at 19:42, on Zulip):

I'm testing salsa itself now

nikomatsakis (Mar 13 2019 at 19:42, on Zulip):

hmm, that seems to build.

Jeremy Kolb (Mar 13 2019 at 19:43, on Zulip):

I believe that's a bug with incremental compilation

Jeremy Kolb (Mar 13 2019 at 19:43, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/issues/826

Jeremy Kolb (Mar 13 2019 at 19:44, on Zulip):

though what you posted looks a little different

nikomatsakis (Mar 13 2019 at 19:45, on Zulip):

ah, interesting

nikomatsakis (Mar 13 2019 at 19:45, on Zulip):

that could be

nikomatsakis (Mar 13 2019 at 19:45, on Zulip):

I don't get the failures on salsa itself

nikomatsakis (Mar 13 2019 at 19:45, on Zulip):

though I get...other test failures

nikomatsakis (Mar 13 2019 at 19:46, on Zulip):

hmm, disabling incremental doesn't seem to help

nikomatsakis (Mar 13 2019 at 19:46, on Zulip):

cc @Vadim Petrochenkov -- do yo know if there were any bug fixes or other changes to name resolution that might be relevant to the error above?

nikomatsakis (Mar 13 2019 at 19:47, on Zulip):

seems like syn::Result is a thing

Jeremy Kolb (Mar 13 2019 at 19:47, on Zulip):

We have https://github.com/rust-lang/rust/issues/58291 filed for this issue. If it's not incremental it may be different

Jeremy Kolb (Mar 13 2019 at 19:47, on Zulip):

I'll try with nightly

Jeremy Kolb (Mar 13 2019 at 20:07, on Zulip):

@nikomatsakis I get the same issue I linked with nightly

nikomatsakis (Mar 13 2019 at 20:08, on Zulip):

i.e., the one you linked above?

nikomatsakis (Mar 13 2019 at 20:08, on Zulip):

ok

Jeremy Kolb (Mar 13 2019 at 20:12, on Zulip):

yeah

Vadim Petrochenkov (Mar 13 2019 at 21:56, on Zulip):

Resolution of paths like syn::Result isn't affected by incremental yet, AFAIK.
Also, there shouldn't be any recent changes in that area.

Vadim Petrochenkov (Mar 13 2019 at 21:57, on Zulip):

Perhaps syn accidentally refers to a local module named syn, or something like that?

nikomatsakis (Mar 14 2019 at 14:30, on Zulip):

@Vadim Petrochenkov not that I know of. This error seems to happen only when building as part of another project, which is strange. I'll try to poke at a bit more today and see if I can reduce.

Last update: Nov 19 2019 at 18:25UTC