Stream: t-compiler/wg-rls-2.0

Topic: rust-analyzer#792 `rust-project.json `


davidtwco (Mar 05 2019 at 18:15, on Zulip):

@matklad I started on this yesterday. I've got something that builds and I think all it needs are some tests - I was wondering how you envisioned testing this before I start digging too deep into that?

matklad (Mar 05 2019 at 18:15, on Zulip):

So this is about the impure "outer" layer of rust analyzer. For these things, I think integration tests work best

matklad (Mar 05 2019 at 18:16, on Zulip):

We have a couple of em in heavy_tests folder

davidtwco (Mar 05 2019 at 18:16, on Zulip):

Great, I'll look there. I've got something implemented that I think makes sense, but I probably won't think of all the edge cases that there might be straight away.

matklad (Mar 05 2019 at 18:18, on Zulip):

I don't think we need to think about all edge cases, we can fix them as we go

matklad (Mar 05 2019 at 18:19, on Zulip):

also cc @Taylor Cramer : this is about make rust-analyzer working without Cargo, I think you might be interested in this as well.

davidtwco (Mar 05 2019 at 21:13, on Zulip):

@matklad One problem I'm running into is that I can't specify a absolute path in the rust-project.json file in my test (as that gets written in a random tmp directory) but the vfs code expects absolute paths (because that's what Cargo normally is providing). Any ideas?

davidtwco (Mar 05 2019 at 21:14, on Zulip):

(at least, that's my understanding of why I'm seeing exactly nothing work)

matklad (Mar 05 2019 at 21:21, on Zulip):

Hm, how tmp sir prevents using an abs path?

davidtwco (Mar 05 2019 at 21:27, on Zulip):

Nevermind, managed to fix it.

davidtwco (Mar 05 2019 at 21:36, on Zulip):

@matklad rust-analyzer#939

davidtwco (Mar 05 2019 at 21:36, on Zulip):

It will likely need a lot of changes, but it's a start.

davidtwco (Mar 06 2019 at 21:35, on Zulip):

@matklad I'm seeing a strange error that I can't explain when working on your review feedback. I get this error for this diff and nothing else has changed. If I undo that, it builds.

Florian Diebold (Mar 06 2019 at 21:44, on Zulip):

@davidtwco that's a compiler bug: rust-analyzer#826

davidtwco (Mar 06 2019 at 21:45, on Zulip):

Huh, interesting. Thanks.

Last update: Nov 19 2019 at 17:45UTC