Stream: t-compiler/wg-rls-2.0

Topic: rls-1.0


marmeladema (Jun 01 2020 at 14:25, on Zulip):

Hello everyone!

I know it might no be the right place to discuss first generation RLS, but i have migrated the save_analysis crate, which is used by RLS if I am not mistaken, to use the HIR tree instead of the AST: https://github.com/rust-lang/rust/pull/72882
I would like to know where/who/how could I properly test this change? It seems that there are not really a lot of those in rustc itself.

Laurențiu Nicola (Jun 01 2020 at 14:26, on Zulip):

@Igor Matuszewski maybe?

Jonas Schievink (Jun 01 2020 at 14:27, on Zulip):

Not sure if ./x.py test --stage 0 src/tools/rls works, but that's the first thing I'd try

marmeladema (Jun 01 2020 at 14:29, on Zulip):

Or those tests ran in CI? I'll run them locally anyway, its just to understand how confident i can be about the CI

Jonas Schievink (Jun 01 2020 at 14:29, on Zulip):

I think they are run by bors, but don't fail the merge when they fail (instead, the tool is marked as broken)

marmeladema (Jun 01 2020 at 14:32, on Zulip):

Ok thanks! I've seen bors complaining about clippy/mirri being broken after a merge :)
Also is there a more appropriate place to discuss rls/save_analysis?

marmeladema (Jun 01 2020 at 14:35, on Zulip):

Damn i can't run tools/rls tests locally because it wants openssl and not libressl :) Have to fix that first

marmeladema (Jun 01 2020 at 15:39, on Zulip):

Well running ./x.py test --stage 0 src/tools/rls did not go well, some tests failed because of rustc version mismatch

marmeladema (Jun 01 2020 at 15:40, on Zulip):
Processing message: Object({"jsonrpc": String("2.0"), "method": String("textDocument/publishDiagnostics"), "params": Object({"diagnostics": Array([Object({"code": String("E0514"), "message": String("found crate `std` compiled by an incompatible version of rustc\n\nhelp: please recompile that crate using this compiler (rustc 1.45.0-dev)\nnote: the following crate versions were found:\n      crate `std` compiled by rustc 1.44.0-beta.752 (a7d891e31 2020-04-21): /home/adema/Sources/rust/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-ddd4722641488d4f.rlib\n      crate `std` compiled by rustc 1.44.0-beta.752 (a7d891e31 2020-04-21): /home/adema/Sources/rust/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-ddd4722641488d4f.so"), "range": Object({"end": Object({"character": Number(0), "line": Number(0)}), "start": Object({"character": Number(0), "line": Number(0)})}), "severity": Number(1), "source": String("rustc")})]), "uri": String("file:///home/adema/Sources/rust/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/rlsit/t3/borrow_error/src/main.rs")})})
Jonas Schievink (Jun 01 2020 at 15:42, on Zulip):

yeah, same here, not sure what's going on

marmeladema (Jun 01 2020 at 15:42, on Zulip):

I am re-trying with --stage 1 instead, lets see

marmeladema (Jun 01 2020 at 15:44, on Zulip):

Ah it errors too on some tests but for real this time :)

marmeladema (Jun 01 2020 at 16:01, on Zulip):

So on test is randomly failing oO and the three others are consistently failing but they all contain a comment:

// FIXME: Without `all_targets=false`, this test will randomly fail.
marmeladema (Jun 01 2020 at 16:01, on Zulip):

They seem to consistently fail now :D

Last update: Sep 27 2020 at 14:30UTC