Stream: t-compiler/rust-analyzer

Topic: do_docs_comments

divma (Jan 31 2020 at 04:09, on Zulip):

Could someone elaborate on the purpose of this test?
It's failing with: thread 'docs::no_docs_comments' panicked at 'called Result::unwrap() on an Err value: Custom { kind: InvalidData, error: "stream did not contain valid UTF-8" }',
Specifically, it's failing here

divma (Jan 31 2020 at 04:28, on Zulip):

ok found it... Is some point I had cargo build (or something) inside a crate, so there was a target dir there. Shouldn't the test ignore all target dirs? I mean, I know this one is not supposed to even exist but still

detrumi (Jan 31 2020 at 07:33, on Zulip):

I don't think we can just blacklist it recursively, because someone might name a crate target

matklad (Jan 31 2020 at 09:16, on Zulip):

I do think if path.contains("target") would be good enough

divma (Jan 31 2020 at 10:59, on Zulip):

new mini issue then?

Last update: Jul 24 2021 at 20:15UTC