Good morning @matklad ! I was curious if there's anything else I need to do for https://github.com/rust-analyzer/rust-analyzer/pull/4587 or https://github.com/rust-analyzer/rust-analyzer/pull/4743. I wasn't sure how often I should try to rebase to keep it up to date in case that's messing up the reviews (losing comment context). I also didn't want to pester anyone by hitting the request review every few days. For this project at least, how often should I ping for an update?
I'm also in no rush here. They're simple and small enough to maintain for a while
Yeah, I didn't have a chance to review those properly yet (have been busy with rewriting the VFS)
No worries, I'll circle back in a while then. Any issue with rebasing when conflicts come up?
No, we actually prefer rebase approach
Ok, sounds good. Thanks for the quick respone!