Stream: t-compiler/rust-analyzer

Topic: Wrongly placed diagnostics ?


Thomas Vigouroux (Jan 19 2021 at 07:55, on Zulip):

Hello there, I am pretty sure this is not the correct way to ask question / report problems, but I wanted to informally ask something.

I am coming here from a bug I face using ra + neovim (and the built-in client we are working on): the issue.

I am not sure this is spec compliant, and anyway, do you think we should fix the issue on our end, or that r-a can avoid sending diagnistics past the end of the text file ?

Thanks in advance, and thanks for this awesome tool, every single update is just a massive step forward, you guys are the best, keep up the great work !

matklad (Jan 19 2021 at 08:48, on Zulip):

That's a bug with macros it seem (cc @Edwin Cheng ). We should fix it and add a relevant assert...

matklad (Jan 19 2021 at 08:49, on Zulip):

scratch that, ther's unclosed quote...

matklad (Jan 19 2021 at 08:51, on Zulip):

Ok, apparently it is neovim issue? https://github.com/neovim/neovim/issues/13476#issuecomment-762674734

Laurențiu (Jan 19 2021 at 09:09, on Zulip):

There's an unclosed quote and diagnostics at the end of the file aren't so unusual, but the range is a bit weird

Laurențiu (Jan 19 2021 at 09:10, on Zulip):

Lines 21-24 (0-based I suppose)

Thomas Vigouroux (Jan 19 2021 at 10:10, on Zulip):

Oh sorry for the noise then, as is seems to come from our side !

matklad (Jan 19 2021 at 10:14, on Zulip):

No worries, I am personally very interested in rust-analyzer support in neovim, feel free to reach out at any time!

Edwin Cheng (Jan 19 2021 at 10:40, on Zulip):

if there is any syntax error, mbe should not be able to expand (because of token_tree_to_syntax_node will fail), but I have not tested it

Edwin Cheng (Jan 19 2021 at 10:42, on Zulip):

And I am neovim happy user too ^^

matklad (Jan 19 2021 at 11:07, on Zulip):

wow, I didn't realize that! @Edwin Cheng are you on neovim 0.5 with built-in lsp?

Last update: Jul 27 2021 at 21:30UTC