ra_lsp_server binary is renamed to
rust-analyzer in the master branch
ra_lsp_server was fine...
@std::Veetaha it now does
ra_cli things so the new name is more appropriate
it's not a big deal :)
I'll miss old times...
this will also break @Edwin Cheng 's analysis stats page :disappointed:
What is that page?
I just fixed it two times today :joy:
And I agreed the new name is more appropriate too.
(btw, that page is getting a bit slow, I want to implement some kind of pagination for it some time :sweat_smile: )
:ok:🏻 Let’s me implement it in this weekend.
Um, are those commit numbers under the graph useful?
Would be great to explicitly mention somewhere that
rust-analyzer.raLspServerPathsetting needs a new value
Hm, should we also rename the
It's already renamed
pasted image Am I holding it wrong?
Looks the same for me
there used to be less of them ;)
Thats why it need pagination :joy:
Nah, it's fine without the labels
@Kirill Bulatov Don't worry, this won't affect the VSCode release download in any way, our code is resistant to that
Though, yeah, we will leave an unused
ra_lsp_server[-os][.exe] binary at users filesystem...
Kirill Bulatov Don't worry, this won't affect the VSCode release download in any way, our code is resistant to that
prebuiltServerFileName() was updated in the same PR, right?
Right, this was the single source of truth
I guess we may save binaries under different name on users PC, so that we don't leave grabage when we rename stuff, but nah...)
Failed to download language server from rust-analyzer GitHub repository: Cannot destructure property `downloadUrl` of 'undefined' or 'null'.
perhaps that is related?
Yes, it is realted. The new extension only works at the moment if you build the server from source, and set
rust-analyzer.serverPath config to
it worked, thanks! :+1:
@matklad , this is why I put an assert there initally, I knew we would have this problem....
@Florian Diebold pagination is added :)
Great :tada: loads much faster :)
Neat, way better.
Although current picture is too good to be true, isn't it? :)
Would it make sense to add projects that heavily depend on macros?
nalgebra or something that uses them?
Well, maybe some other time then.
I think it is a good idea to test on these crates, let me find a way to include more crates without much effort.