Stream: t-compiler/rust-analyzer

Topic: Caching `Semantics`


Laurențiu (Jul 01 2020 at 08:32, on Zulip):

Should code try to reuse Semantics? There's an ImportsLocator that could easily get an instance but makes a new one instead.

matklad (Jul 01 2020 at 08:35, on Zulip):

In generally we should, yeah

matklad (Jul 01 2020 at 08:35, on Zulip):

I guess Imports locator should just accept semantics as an argument

matklad (Jul 01 2020 at 08:35, on Zulip):

(if it should use it at all)

Laurențiu (Jul 01 2020 at 08:35, on Zulip):

Hm, or maybe not so easily (it takes ownership)

Laurențiu (Jul 01 2020 at 11:03, on Zulip):

There's quite a bit of code that calls sema.db only to make another Semantics later :D

Last update: Jul 27 2021 at 21:00UTC