Stream: t-compiler/rust-analyzer

Topic: Tests for diagnostic fixes


Jonas Schievink [he/him] (May 07 2021 at 13:33, on Zulip):

I can't seem to find any tests for the "Fill struct fields" quick fix, do we have any for that?

Jonas Schievink [he/him] (May 07 2021 at 13:33, on Zulip):

If not, where should they go?

matklad (May 07 2021 at 14:01, on Zulip):

Commenting the fix our shows the following failtures:

failures:
diagnostics::tests::range_mapping_out_of_macros
diagnostics::tests::test_fill_struct_fields_empty
diagnostics::tests::test_fill_struct_fields_enum
diagnostics::tests::test_fill_struct_fields_partial
diagnostics::tests::test_fill_struct_fields_self

matklad (May 07 2021 at 14:02, on Zulip):

I think we probably should have one file per diagnostics, which contains both the diagnostics, the fix, and the tests

matklad (May 07 2021 at 14:02, on Zulip):

basically, the same org we use for assists

Last update: Jul 27 2021 at 22:30UTC