What's the reason for not publishing the
ra_* crates on crates.io?
Is it because it's a workspace and therefore not enough automation? Or is it versioning concerns?
The main work is that, if we publish things, someone needs to make decsisions about when to publish, what versioning scheme to use, etc
Since we don't consider it stable, can't we publish a minor version every monday? For example, 0.2.0 this monday, 0.3.0 next monday, like that until we make the decision to make it stable
@Laurențiu Nicola Can you please set this to Draft PR? https://github.com/rust-analyzer/rust-analyzer/pull/5713. I messed up when creating it
@pksunkara I don't have the rights to do so, but you should be able to. Is there a link on the right side, under the reviewers section? It says "convert to draft". That's where it is in the new GitHub UI, at least.
@matklad Great work on the renames. :+1:
I sent 2 renaming PRs which should not have any conflicts. https://github.com/rust-analyzer/rust-analyzer/pull/5734 and https://github.com/rust-analyzer/rust-analyzer/pull/5735
Renamed all crates & set the version to 0.0.0
https://github.com/rust-analyzer/rust-analyzer/pull/4776#issuecomment-679040531, I can put the description as TBD for now
But I just wanted to confirm with you before doing it
Yeah, if we have to put the descriptions, let's put somethign
Okay, will do
Done. The PR is now ready. Please don't forget to add the
Waiting for you to trigger another publish run :innocent:
Auto publishing successfully finished. Thanks for the patience. Just ping me here if anything goes wrong.
NOTE: These are the triggers for publishing. Please double check.
tbh, I don't have a good feeling for what the trigger should be. Current one looks fine. We might just re-use the one from nightly/release as well.
So, I need this
load_cargo function but we haven't published rust-analyzer. I am honestly not sure what to do here. Should I just publish
ra_ap_rust-analyzer or try to extract this code to a different crate?
I think publishing ra_ap_ra is the simplest here
cargo install ra_ap_rust-analyzer should work
@matklad Just wanted to say thanks for helping me publish the crates. I have successfully built a prototype for analysis tools based on rust-analyzer. https://github.com/pksunkara/cargo-up. It has a visitor defined https://github.com/pksunkara/cargo-up/blob/master/cargo-up/src/lib/visitor.rs which other tools can copy or use directly. An example of how this tool can be used to upgrade code in clap is https://github.com/clap-rs/clap/blob/master/clap_up/src/lib.rs. Would love your opinion
oh that's cool!
@pksunkara took a peek, looks resonable.
I'd love to see SSR capabilities enhanced to enable these kinds of transformations declaratively, but i am unsure what that API should look like
Yeah, that would be a good start. But I'm unsure if SSR (even with enhancements) would be capable of doing more complex stuff
Well, we might try to nerd-snipe @David Lattimore :D
Thanks @Jeremy Kolb . It still needs a lot of work but my hope is that we can use this to automatically move code to 2021 edition when it happens
For the 2018 edition there were a bunch of lints in the compiler that made code compatible with both 2015 and 2018 at the same time.
cargo fix could then automatically apply the suggestions.
Can someone merge this PR to unblock the weekly automated publishing? https://github.com/rust-analyzer/rust-analyzer/pull/6420
Anyone have any idea why the code is not compiling on publish? https://github.com/rust-analyzer/rust-analyzer/runs/1680381794?check_suite_focus=true#step:5:1499
I thought bors would have caught this.
some feature is activated in a different cargo.toml?
#[cfg(feature = "unbounded_depth")]
heh, I thought bors tests everything in the workspace together