Stream: t-compiler/rust-analyzer

Topic: grayed-out cfg is <3


matklad (Nov 10 2020 at 22:16, on Zulip):

@Jonas Schievink I am adding features to the once_cell crate, and the new handling of #[cfg] attributes is so nice!

If I didn't knew the hacky way it is implemented, I'd assumed a first-class feature :D

Jonas Schievink [he/him] (Nov 10 2020 at 22:16, on Zulip):

Cool!

Jonas Schievink [he/him] (Nov 10 2020 at 22:17, on Zulip):

What's so hacky about it though? It's not particularly clean, but everything happens in the right places IMO (at least in the current architecture)

matklad (Nov 10 2020 at 22:21, on Zulip):

Like, the fact that it is an unused diagnostics, which just doesn't show an error

Jonas Schievink [he/him] (Nov 10 2020 at 22:22, on Zulip):

Oh, okay

Jonas Schievink [he/him] (Nov 10 2020 at 22:22, on Zulip):

Yeah, I suppose it's not really meant for this :D

Jonas Schievink [he/him] (Nov 10 2020 at 22:23, on Zulip):

But it fits well, and looks exactly like it should in VS Code

Paul Faria (Nov 11 2020 at 00:23, on Zulip):

It's also going to make testing the cfg configuration REALLY easy on the front-end.

Dirkjan Ochtman (Nov 11 2020 at 12:17, on Zulip):

I also love it FWIW :)

woody77 (Dec 01 2020 at 23:39, on Zulip):

editorUnnecessaryCode.opacity is the theme setting for it:

"editorUnnecessaryCode.opacity": "#0007",

Last update: Jul 28 2021 at 04:00UTC