Stream: t-compiler/rust-analyzer

Topic: lsp text document sync incremental


Hoang Luu (Oct 25 2019 at 15:00, on Zulip):

Currently, RA only support document sync with Full mode

        text_document_sync: Some(TextDocumentSyncCapability::Options(TextDocumentSyncOptions {
            open_close: Some(true),
            change: Some(TextDocumentSyncKind::Full),
            will_save: None,
            will_save_wait_until: None,
            save: None,
        })),

Is it feasible to implement SyncKind::Incremental?

matklad (Oct 25 2019 at 15:15, on Zulip):

Totally feasible, just not a high priority: full file sync seems to work
rather fast anyway.

Laurențiu (May 27 2021 at 12:40, on Zulip):

This has been available for a while and I don't think we've had any recent issues with it. Should we remove the fallback option?

matklad (May 28 2021 at 09:59, on Zulip):

Yeah, let's remove it.

matklad (May 28 2021 at 10:00, on Zulip):

Might make sense to search existing issues with "incremental" -- I recall seeing some still-opende issue during the triage, but I might be misremembering

Laurențiu (May 28 2021 at 10:02, on Zulip):

There's a couple of them, but I'm not sure they're related to this: https://github.com/rust-analyzer/rust-analyzer/issues?q=is%3Aissue+is%3Aopen+incremental+sync

Laurențiu (May 28 2021 at 10:04, on Zulip):

At least not after https://github.com/rust-analyzer/rust-analyzer/pull/5659

Laurențiu (May 28 2021 at 10:07, on Zulip):

Hmm

Laurențiu (May 28 2021 at 10:09, on Zulip):

https://github.com/rust-analyzer/rust-analyzer/issues/4829 doesn't look great

Last update: Jul 28 2021 at 03:30UTC