Stream: t-compiler/rust-analyzer

Topic: vscode_extension_config

std::Veetaha (Feb 11 2020 at 23:17, on Zulip):

I am working on reworking our config in vscode extension. It seems we do have conflicting defaults (as we have up to 3 sources of truth there).
highlightingOn default was set to false in package.json, but we missed to change this in class Config.
I guess now the effective default is false, but do we leave it false anyway, @matklad ?

std::Veetaha (Feb 11 2020 at 23:29, on Zulip):

One more inconsistency is in "cargo-watch.command".
In package.json it is "check", in code it is an empty string, can you please elaborate @Emil Lauridsen ?

Emil Lauridsen (Feb 12 2020 at 07:14, on Zulip):

I just adapted what was there from the original VSCode only implementation, so I'm not sure what the original idea was.

std::Veetaha (Feb 12 2020 at 20:59, on Zulip):

@matklad , can you also please clarify on withSysroot setting? Is it an implementation detail that is not exposed to users (though they can specify it, but they are not supposed to)?

matklad (Feb 12 2020 at 21:03, on Zulip):

Yep, it exists solely for devs of rust-analyzer itself

std::Veetaha (Feb 12 2020 at 22:43, on Zulip):

@matklad I see "trace.server" setting is not used, should we remove it from package.json?

matklad (Feb 12 2020 at 22:54, on Zulip):

It definitely works in that you need to set it to see the log of
requests. I think it’s a client-side only setting?

std::Veetaha (Feb 12 2020 at 23:07, on Zulip):

@matklad , I don't see it to be referenced in our client code. See this PR where it was introduced, I don't see where it was referenced even then...

matklad (Feb 12 2020 at 23:32, on Zulip):

Hm, interesting, I definitelly enabled and disable traces regurarly, and I think it goes via that setting and works? Am I imagning things? Or is this somehow just picked up by VS Code automatically?

std::Veetaha (Feb 13 2020 at 09:23, on Zulip):

@matklad, which way do you enable and disable traces? I doubt that this is some "magic" configuration. I haven't found any references in vscode-languageclient (I haven't even found any docs on this module on their GitHub)

matklad (Feb 13 2020 at 09:34, on Zulip):

I need config on the left to see stuff on the right

matklad (Feb 13 2020 at 09:34, on Zulip):

pasted image

matklad (Feb 13 2020 at 09:35, on Zulip):

matklad (Feb 13 2020 at 09:36, on Zulip):

it is a magic thing

std::Veetaha (Feb 13 2020 at 09:38, on Zulip):

Aha, yes, I somehow did miss this, when doing a search through thier vscode-language* repo...

Last update: Jul 26 2021 at 14:00UTC