I am working on reworking our config in vscode extension. It seems we do have conflicting defaults (as we have up to 3 sources of truth there).
highlightingOn default was set to
package.json, but we missed to change this in
I guess now the effective default is
false, but do we leave it
false anyway, @matklad ?
I just adapted what was there from the original VSCode only implementation, so I'm not sure what the original idea was.
@matklad , can you also please clarify on
withSysroot setting? Is it an implementation detail that is not exposed to users (though they can specify it, but they are not supposed to)?
Yep, it exists solely for devs of rust-analyzer itself
@matklad I see
"trace.server" setting is not used, should we remove it from
It definitely works in that you need to set it to see the log of
requests. I think it’s a client-side only setting?
@matklad , I don't see it to be referenced in our client code. See this PR where it was introduced, I don't see where it was referenced even then...
Hm, interesting, I definitelly enabled and disable traces regurarly, and I think it goes via that setting and works? Am I imagning things? Or is this somehow just picked up by VS Code automatically?
@matklad, which way do you enable and disable traces? I doubt that this is some "magic" configuration. I haven't found any references in
vscode-languageclient (I haven't even found any docs on this module on their GitHub)
I need config on the left to see stuff on the right
it is a magic thing
Aha, yes, I somehow did miss this, when doing a search through thier