Stream: t-compiler/rust-analyzer

Topic: rust.ungram didnt update on publish


Lukas Wirth (Dec 16 2020 at 12:05, on Zulip):

I'm not sure why but for some reason the 1.3.0 ungrammar release doesn't contain the new ungrammar https://docs.rs/crate/ungrammar/1.3.0/source/rust.ungram

Lukas Wirth (Dec 16 2020 at 12:06, on Zulip):

The macro 2.0 stuff landed in it, but the lifetime changes are missing

Lukas Wirth (Dec 16 2020 at 12:06, on Zulip):

oh

Lukas Wirth (Dec 16 2020 at 12:07, on Zulip):

Jonas Schievink published 1.3.0 10 minutes before i merged this that explains it :big_smile:

matklad (Dec 16 2020 at 12:08, on Zulip):

So you need another PR with version bump?

Lukas Wirth (Dec 16 2020 at 12:10, on Zulip):

Yep would need another, though maybe its better to wait for the macro 2.0 PR to get done first since I probably need to rebase my stuff on it then anyways, since that will most likely have a few required changes to compile as well?

matklad (Dec 16 2020 at 12:20, on Zulip):

@Jonas Schievink you are now officially in charge of merging lifetimes node-ification work :D

Jonas Schievink [he/him] (Dec 16 2020 at 12:35, on Zulip):

ungrammar 1.4.0 is published

Lukas Wirth (Dec 16 2020 at 13:08, on Zulip):

Rebased my PR on yours with ungrammar set to 1.4 and codegen regenerated :thumbs_up:

Last update: Jul 24 2021 at 20:45UTC