Stream: t-compiler/rust-analyzer

Topic: Pre commit hook


matklad (Mar 01 2021 at 17:33, on Zulip):

Is anybody using our pre-commit hook?

matklad (Mar 01 2021 at 17:34, on Zulip):

I want to remove it, as I haven't used it for years -- creates more hassle when rustfmt fails to parse something

Jonas Schievink [he/him] (Mar 01 2021 at 17:37, on Zulip):

there's a pre-commit hook?

Lukas Wirth (Mar 01 2021 at 17:39, on Zulip):

Iirc it invokes rustfmt right? I tried it once I think but got annoyed by how long it delayed the commit command so I removed it again

Laurențiu (Mar 01 2021 at 17:39, on Zulip):

No, I don't use it. Yeah, it's documented in https://github.com/rust-analyzer/rust-analyzer/tree/master/docs/dev#ci.

Edwin Cheng (Mar 01 2021 at 17:39, on Zulip):

I remember that pre-commit hook was not working in Windows.

matklad (Mar 01 2021 at 17:42, on Zulip):

I guess that answers my question...

Jeremy Kolb (Mar 01 2021 at 17:53, on Zulip):

Remove it. It doesn't work on windows. Or at least my windows.

Kirill Bulatov (Mar 01 2021 at 17:53, on Zulip):

I use it actually, but fine without it either.

It also spoils the partial git add, I've spent half an hour the first time it occurred :smile:

Last update: Jul 24 2021 at 19:30UTC