Is anyone available to review my PRs (https://github.com/rust-analyzer/rust-analyzer/pull/4043 , https://github.com/rust-analyzer/rust-analyzer/pull/4207 ) ? in fact I will have some free time this weekend to edit them if needed. So it would be great if you have time to take a look :)
@Edwin Cheng Thanks for your review. I updated the PR :) I really apreciated
You are welcome. :heart:️
I think Github UI is quite complicated that marking it resolved in comments for PR is quite useful for reviewers.
Ok I marked your comments to resolved :)
@matklad let me know which limit you prefer :)
@Edwin Cheng do you want I make a PR to resolve this comment https://github.com/rust-analyzer/rust-analyzer/pull/4285#discussion_r419200375 ?
That would be great <3
Ok I add this on my TODO list :)
@matklad is it possible for you to review this PR https://github.com/rust-analyzer/rust-analyzer/pull/4043 ? It's waiting for review for 2 weeks now and I think this feature is pretty useful. I already use it on some projects. I'm open to any suggests :)
I'll try to get to it this week :)
Thanks a lot :)
@matklad if you have time I finished your review here https://github.com/rust-analyzer/rust-analyzer/pull/4043 :D