Stream: t-compiler/help

Topic: rustc_std_internal_symbol


Amanieu (Dec 26 2019 at 14:41, on Zulip):

@Alex Crichton Is there a reason why libpanic_abort uses #[rustc_std_internal_symbol] while libpanic_unwind uses #[no_mangle] instead?

simulacrum (Dec 26 2019 at 14:56, on Zulip):

I think it's just a mistake

simulacrum (Dec 26 2019 at 14:57, on Zulip):

@Amanieu fwiw, I'm planning on updating my PR shortly which should make our implementation as good as C++ examples I can test

Amanieu (Dec 26 2019 at 14:59, on Zulip):

@simulacrum Oh dear, I'm almost done with my PR which also does exactly that :D

simulacrum (Dec 26 2019 at 14:59, on Zulip):

well maybe good to compare

Amanieu (Dec 26 2019 at 15:09, on Zulip):

@simulacrum https://github.com/rust-lang/rust/compare/master...Amanieu:catch_unwind

simulacrum (Dec 26 2019 at 15:09, on Zulip):

https://github.com/rust-lang/rust/pull/67502 -- I ended up updating my previous branch

simulacrum (Dec 26 2019 at 15:11, on Zulip):

Looks almost exactly like mine modulo additional fixes to emcc

simulacrum (Dec 26 2019 at 15:13, on Zulip):

@Amanieu do you want to make the PR then? I can close mine out

Amanieu (Dec 26 2019 at 15:22, on Zulip):

@simulacrum We can use yours as a base. I will add some feedback in a bit (somewhat busy atm).

simulacrum (Dec 26 2019 at 15:23, on Zulip):

Okay, sounds good -- feel free to push to my branch as well (you should have rights I think).

simulacrum (Dec 26 2019 at 15:47, on Zulip):

Cherry picked a few of your commits

Alex Crichton (Jan 06 2020 at 15:07, on Zulip):

@Amanieu back from break now and can follow up! @simulacrum is right here in that it's probably just a mistake, the main difference is symbol visibility in final cdylib/dylib artifacts, where we want these internal symbols hidden whereas normal no_mangle symbols are exported

Last update: Sep 18 2020 at 20:45UTC