can someone familiar with dataflow comment on whether it's ok to be made public for clippy?
I've done some work on it and think it's fine, but wanted a second opinion
Just a heads up, #64470 contains a more generic dataflow analysis engine needed for const qualification, and I'm planning to make the current one a special-case of that one. I should be able to stay compatible with consumers of the old API though. Also, can we keep
state_for_location private? It makes it too easy to accidentally go quadratic IMO.
@ecstatic-morse FWIW you don't need to stay compatible with the old API
if you change the API, clippy fails to compile, and they'll have to upgrade to the new API
right now clippy is not using it, so maybe consider these type of users for the new API ? (I find the new one much better than the old one, mainly because it is much better documented)