Stream: t-compiler/help

Topic: curious why rustfmt in nightly is missing


Guanqun (Oct 12 2019 at 16:16, on Zulip):

I see from this link https://rust-lang.github.io/rustup-components-history/ the rustfmt is missing these days, and this cause the failure when CI tries to use rustfmt in nightly, how should we address this issue?

mark-i-m (Oct 12 2019 at 19:16, on Zulip):

This happens with a lot of the tools in between releases

mark-i-m (Oct 12 2019 at 19:16, on Zulip):

e.g. https://rust-lang-nursery.github.io/rust-toolstate/

mark-i-m (Oct 12 2019 at 19:16, on Zulip):

During the final week before a release, they have to be fixed and stay fixed.

mark-i-m (Oct 12 2019 at 19:18, on Zulip):

The page above has a link to the commit that broke rustfmt. If you want, you could submit a PR to rustfmt to fix it

Guanqun (Oct 13 2019 at 00:58, on Zulip):

hmm, confused that on that page, the rustfmt shows:

rustfmt test pass test pass 1721c9685 on 2019-10-12 22:05:18

but still no build for this?

Josh Triplett (Oct 13 2019 at 06:40, on Zulip):

Why do we not block commits on tool builds?

Josh Triplett (Oct 13 2019 at 06:40, on Zulip):

Just because they take too long?

centril (Oct 13 2019 at 11:49, on Zulip):

Because they are not in tree so if we block on tool builds we could not get anything that e.g. changes the structure of AST/HIR/... done.
We only block in the last week of a release. Moreover, blocking on tool builds would make doing rollups a nightmare.

Last update: Nov 11 2019 at 22:55UTC