Stream: t-compiler/help

Topic: bors


Camelid (Jun 01 2020 at 21:01, on Zulip):

If my PR is approved and then I make a change, does it have to be re-approved? I'm assuming yes.

Camelid (Jun 01 2020 at 21:02, on Zulip):

Sorry if I'm asking too many questions, let me know if I am!

Jonas Schievink (Jun 01 2020 at 21:02, on Zulip):

Yeah it does

Jonas Schievink (Jun 01 2020 at 21:03, on Zulip):

(don't worry about asking questions, there's plenty of people that can answer them while waiting for a build)

Camelid (Jun 01 2020 at 21:03, on Zulip):

Okay :)

LeSeulArtichaut (Jun 01 2020 at 21:03, on Zulip):

If you feel like you're bothering people, read the "A metaquestion" topic in #t-compiler :D

LeSeulArtichaut (Jun 01 2020 at 21:04, on Zulip):

A lot of compiler experts said that questions never bother them

Camelid (Jun 01 2020 at 21:04, on Zulip):

Should I notify my reviewer somehow or will they just re-approve it?

Camelid (Jun 01 2020 at 21:04, on Zulip):

LeSeulArtichaut said:

If you feel like you're bothering people, read the "A metaquestion" topic in #t-compiler :D

I read some of that thread but I just wanted to make sure :)

mark-i-m (Jun 02 2020 at 03:14, on Zulip):

Camelid said:

Should I notify my reviewer somehow or will they just re-approve it?

Generally, they will come around to it again (because it's still assigned to them on github). Some reviewers (e.g. eddyb) also say you can ping them on zulip because they don't see gh pings as easily, but it depends on who.

Last update: Sep 28 2020 at 15:30UTC