Stream: t-compiler/help

Topic: expected timeline for reviews?


Dirkjan Ochtman (Jun 09 2020 at 20:11, on Zulip):

I made a small std PR (#72994) 6 days ago and haven't gotten any response

Dirkjan Ochtman (Jun 09 2020 at 20:11, on Zulip):

should I ask for a new reviewer? if so, how?

oli (Jun 09 2020 at 20:20, on Zulip):

you can use r? @reviewername to ask for a different reviewer. If you don't know who to ask, posting here is totally fine. Often the triage team gets to PRs after 7 days of no activity, but feel free to act after less than that.

Dirkjan Ochtman (Jun 09 2020 at 20:25, on Zulip):

ahh, would have waited for the triage team if I'd known about that

Dirkjan Ochtman (Jun 09 2020 at 20:26, on Zulip):

thanks for the response -- where should tests go for this stuff?

LeSeulArtichaut (Jun 09 2020 at 20:28, on Zulip):

I'm pretty sure that libraries get tested inside the crates, in #[cfg(test)] modules, just like a regular library crate

Dirkjan Ochtman (Jun 09 2020 at 20:30, on Zulip):

I don't see task or Poll in https://github.com/rust-lang/rust/tree/f981b13921f5504e8b71c70e973953d00ad0ba48/src/libcore/tests

Last update: Jan 22 2021 at 13:30UTC