Stream: t-compiler/help

Topic: Process for fixing clippy?


Josh Triplett (Jun 15 2020 at 07:53, on Zulip):

If I make a change to the compiler, and that necessitates a change to clippy, what's the process for doing so? Can I just commit a change to src/tools/clippy/clippy_lints in the rust-lang/rust repository, or has something changed there?

Josh Triplett (Jun 15 2020 at 07:57, on Zulip):

As far as I can tell from the documentation, it sounds like the process is to make changes directly in rust-lang/rust, and then someone working on clippy will be able to use the subtree bits to synchronize it later.

oli (Jun 15 2020 at 08:38, on Zulip):

yes, you just fix it in tree and someone else takes care of the sync

Josh Triplett (Jun 15 2020 at 08:39, on Zulip):

Awesome, thank you.

Josh Triplett (Jun 15 2020 at 08:39, on Zulip):

@oli What's the right way to compile-test src/tools/clippy/clippy_lints when I'm building?

oli (Jun 15 2020 at 08:56, on Zulip):

./x.py test src/tools/clippy should do it

oli (Jun 15 2020 at 08:56, on Zulip):

but I think some tests are broken right now

oli (Jun 15 2020 at 08:56, on Zulip):

we're not blocking on clippy tests passing yet

oli (Jun 15 2020 at 08:56, on Zulip):

but will be soon

Josh Triplett (Jun 15 2020 at 20:33, on Zulip):

I ended up doing something different that doesn't change the AST, so I didn't have to change clippy.

Josh Triplett (Jun 15 2020 at 20:33, on Zulip):

But thanks for the help!

eddyb (Jul 16 2020 at 12:53, on Zulip):

@Josh Triplett I use ./x.py check src/tools/clippy, which at least will tell you if it still compiles

eddyb (Jul 16 2020 at 12:54, on Zulip):

(and doesn't require building the compiler twice or w/e)

Last update: Sep 27 2020 at 12:45UTC