Stream: t-compiler/help

Topic: 3 ui tests fail for me locally


Santiago Pastorino (Jun 26 2019 at 13:32, on Zulip):

I'm not sure if this was already discussed and others are having a similar problem but I'm constantly getting ...

Santiago Pastorino (Jun 26 2019 at 13:32, on Zulip):
failures:
    [ui] ui/proc-macro/invalid-punct-ident-1.rs
    [ui] ui/proc-macro/invalid-punct-ident-2.rs
    [ui] ui/proc-macro/invalid-punct-ident-3.rs

test result: FAILED. 5685 passed; 3 failed; 21 ignored; 0 measured; 0 filtered out
Santiago Pastorino (Jun 26 2019 at 13:33, on Zulip):

on my local machine, then I push my code and the those tests pass on the CI

Santiago Pastorino (Jun 26 2019 at 13:35, on Zulip):

this https://gist.github.com/spastorino/58b622690a37b24e394f3948c05b4d84 is the full output

oli (Jun 26 2019 at 16:02, on Zulip):

this just happens on stage 1, right?

Santiago Pastorino (Jun 26 2019 at 16:03, on Zulip):

it happens on stage 1, unsure what would happen on stage 2

oli (Jun 26 2019 at 16:04, on Zulip):

yea, these tests probably need a stage 1 skip comment, I don't remember the wording though

oli (Jun 26 2019 at 16:04, on Zulip):

look in ui-fulldeps, I think there are some comments in some files about stages

Santiago Pastorino (Jun 26 2019 at 16:39, on Zulip):

@oli // ignore-stage1

Santiago Pastorino (Jun 26 2019 at 16:39, on Zulip):

but I wonder, does that happen to the rest of the people?

Santiago Pastorino (Jun 26 2019 at 16:39, on Zulip):

I thought it was just me

oli (Jun 26 2019 at 16:41, on Zulip):

idk

Wesley Wiser (Jun 26 2019 at 17:28, on Zulip):

I get it as well when building stage1

Santiago Pastorino (Jun 26 2019 at 18:09, on Zulip):

@oli https://github.com/rust-lang/rust/pull/62157

Santiago Pastorino (Jun 27 2019 at 03:18, on Zulip):

for the record these 3 tests fail when RUST_BACKTRACE is enabled

Santiago Pastorino (Jun 27 2019 at 14:32, on Zulip):

@Vadim Petrochenkov about this, is expected that these tests fail when we turn on backtraces or not?, to be honest I'm on mobile right now and didn't put a lot of attention to them

Vadim Petrochenkov (Jun 27 2019 at 14:37, on Zulip):

https://github.com/rust-lang/rust/issues/59998 may be related?

Vadim Petrochenkov (Jun 27 2019 at 14:39, on Zulip):

It's expected than panicking in a proc macro will be caught and produce a regular error in rustc (without any backtraces), but this doesn't always happen apparently.

Last update: Nov 11 2019 at 22:00UTC