Stream: t-compiler/help

Topic: UI test stderr line numbers


Camelid (Jun 14 2020 at 00:56, on Zulip):

Why do UI test stderr files have LL for the line number in the gutter, but not for the line and column number shown after the filename?

For example:

error: invalid register `invalid`: unknown register
  --> $DIR/issue-72570.rs:9:18
   |
LL |         asm!("", in("invalid") "".len());
   |                  ^^^^^^^^^^^^^^^^^^^^^^
nagisa (Jun 14 2020 at 01:07, on Zulip):

To avoid minor changes (like comments being added etc) to the source file from also impacting the expected output template much, maybe?

Vadim Petrochenkov (Jun 14 2020 at 07:10, on Zulip):

https://github.com/rust-lang/rust/issues/46643

Camelid (Jun 14 2020 at 20:27, on Zulip):

@Vadim Petrochenkov Is the reason for not anonymizing the line and column in --> $DIR/file.rs:line:column so that one can catch bugs where the compiler prints the wrong line or column?

Vadim Petrochenkov (Jun 14 2020 at 20:30, on Zulip):

Not only bugs, but without line numbers .stderr files become entirely unreadable.

Vadim Petrochenkov (Jun 14 2020 at 20:32, on Zulip):

It would be great to keep all line numbers for readability, but then we have the diff issues (which harm reviews as well).
It's an evil vs greater evil situation.

Last update: Sep 28 2020 at 16:15UTC