Stream: t-compiler/help

Topic: perf requests


lcnr (May 30 2020 at 20:22, on Zulip):

Can someone run perf for https://github.com/rust-lang/rust/pull/72776 again?

lcnr (May 31 2020 at 15:27, on Zulip):

Can someone run perf for https://github.com/rust-lang/rust/pull/72822? (done, thanks :heart: )

lcnr (Jun 03 2020 at 22:06, on Zulip):

Can someone run perf for https://github.com/rust-lang/rust/pull/72962? Have to sleep now.

lcnr (Jun 03 2020 at 22:24, on Zulip):

Seems like I made a mistake with using Lrc... should now be fixed and can be restarted x.x

lcnr (Jun 04 2020 at 22:19, on Zulip):

Can someone rerun perf for https://github.com/rust-lang/rust/pull/72962?
I now cache ObligationCause::dummy. I previously had a few million copies of it on the heap... I have to admit I don't
know if this number of allocations is actually relevant :sweat_smile:

Jonas Schievink (Jun 04 2020 at 22:20, on Zulip):

neat!

mark-i-m (Jun 05 2020 at 02:50, on Zulip):

Where is the :heap: emoji?

Camelid (Jun 05 2020 at 03:49, on Zulip):

:trash_can: (that's the closest I could think of)

lcnr (Jun 05 2020 at 07:15, on Zulip):

Finished benchmarking try commit (ba0ecc9): comparison url.

I can't access thhat commit :oh_no: apparently My PR is still in the perf queue?

Queue (10 total):
Times are local.
Commit Date SHA Reason
try commit 8ff82fab989f4 TryCommit
6/4/2020, 4:16:13 PM 3d5d0f898c2f3 TryParent
try commit ba0ecc9e775e6 TryCommit // <- my PR

lcnr (Jun 05 2020 at 17:06, on Zulip):

Ok... I removed another few hundred thousand small allocations. Not sure if we want to perf it again or just merge it with rollup=never

Feel free to either review or start another perf run :sparkles:

lcnr (Jun 05 2020 at 22:18, on Zulip):

Can someone perf https://github.com/rust-lang/rust/pull/71154? Let's see how far my current approach can get...

lcnr (Jun 07 2020 at 12:16, on Zulip):

^ it seems like that PR didn't actually get added to the perf queue :thinking:

lcnr (Jun 09 2020 at 12:44, on Zulip):

Can someone perf https://github.com/rust-lang/rust/pull/71154 again, I think this new approach might be better... :oh_no:

lcnr (Jun 09 2020 at 21:47, on Zulip):

Did this try build get cancelled due to a merge conflict? Or is this message sent once the PR is added to the queue? https://github.com/rust-lang/rust/pull/71154#issuecomment-641267489

LeSeulArtichaut (Jun 09 2020 at 21:54, on Zulip):

Given that it’s not in the homu queue anymore, I’d guess it got cancelled

lcnr (Jun 10 2020 at 19:01, on Zulip):

Well, let's try https://github.com/rust-lang/rust/pull/71154 again, please perf :sweat_smile:

Last update: Sep 28 2020 at 16:15UTC