Wannabe contributor here. I'm trying to run tests on current master (
./x.py test --stage 1) but I get 5 failures. Are these supposed to fail, or did I make a mistake in my setup (e.g. using my own llvm as described in the book)? The errors
If this is not the right place to ask, please let me know.
Should have the error message before this summary. Can you post them?
trying to run the fail tests ...
Thanks for taking a look. Updating all submodules didn't help.
Looks like they're all ui errors. It looks like someone forgot to
--bless, but that couldn't get past CI, I assume?
All failing tests passes on my machine.
Did you change Rust source somewhere?
No, it's clean
I only edited the configuration file, following the book
Any other tips on how I could diagnose this?
do you by chance have parallel-compiler = true on?
Can you post a
diff config.toml.example config.toml?
@simulacrum I do, that's probably it then. If I don't write in this thread in a couple of minutes, consider this fixed.
yeah I would leave it off, it's not tested in CI beyond x.py check working and isn't likely to bring too many wins at this point if any
I hate to be cynical, but isn't rust supposed to make writing parallel code easier? Minimal gains I can understand, but different compilation results without any notification... Hm.
we haven't spent a lot of time on it
well, those tests are "known to have different results"
because all of them are cycle errors
so it's somewhat expected that parallel execution will lead to slightly different evaluation order and such
Okay, thanks for clarifying a bit what's at play!