Stream: t-compiler/wg-diagnostics

Topic: alternative for term_size


Yuki Okushi (Jan 02 2020 at 03:55, on Zulip):

Hi @Esteban Küber, happy new year! You introduced term_size in #63402 but it seems unmaintained and uses old dependencies. I forked it and fixed a potential off-by-one error and done some clean-up, then released as termize. It can be an alternative?
termize: https://github.com/JohnTitor/termize

Esteban Küber (Jan 02 2020 at 05:53, on Zulip):

That should be fine, there are other crates with similar features we could also use, but I would think some would even prefer to mainline the code into rustc

Esteban Küber (Jan 02 2020 at 05:53, on Zulip):

But yeah, I'm not attached

Esteban Küber (Jan 02 2020 at 05:53, on Zulip):

I'm away until next week

Esteban Küber (Jan 02 2020 at 16:07, on Zulip):

@Yuki Okushi ^^

Yuki Okushi (Jan 03 2020 at 08:39, on Zulip):

okay, we can replace it, or even remove easily enough since it's small code, I think

Yuki Okushi (Jan 03 2020 at 08:40, on Zulip):

let's work on it when you come back :)

Yuki Okushi (Jan 07 2020 at 09:22, on Zulip):

@Esteban Küber okay, I've prepared two draft branches:

which do we prefer?

pksunkara (Jan 16 2020 at 21:17, on Zulip):

I would vote for the first option (if my vote counts :D) since it allows other people to use the fix too.

Last update: Apr 05 2020 at 01:35UTC