Stream: wg-secure-code

Topic: Safety dance – Image


HeroicKatora (Sep 01 2019 at 16:01, on Zulip):

@Shnatsel About https://github.com/rust-secure-code/safety-dance/pull/26, what's the criterion for naming people here? Because the initial PR to remove all unsafety for 0.22 was done by https://github.com/fintelia. My role was more of a maintainer hence the fixing PR is co-authored by me and did the impact post mortems. It was afterwards that I was stubborn enough to backport them to 0.21.

Shnatsel (Sep 01 2019 at 16:03, on Zulip):

I try to name everyone involved in the cleanup efforts so that nobody is upset :D

Shnatsel (Sep 01 2019 at 16:05, on Zulip):

I recall you opening https://github.com/image-rs/image/pull/985 so I've added you

HeroicKatora (Sep 01 2019 at 16:08, on Zulip):

Ah, well that was a rebase of the original large scale cleanup PR: https://github.com/image-rs/image/pull/887
It was split into three parts (#985 being the third and final one) to make reviewing and backporting easier.

Shnatsel (Sep 01 2019 at 16:17, on Zulip):

I see, thanks for the clarification! I guess I'll ping fintelia on the PR and ask if they'd prefer to be credited as part of safety-dance or separately.

Last update: Nov 11 2019 at 23:25UTC