Stream: t-compiler/const-eval

Topic: do not borrow non-Sync data in constants #54424


centril (Sep 24 2019 at 22:01, on Zulip):

well, we could start with a future incompat lint based on https://github.com/rust-lang/rust/pull/54424

I think we should yes

centril (Sep 24 2019 at 22:01, on Zulip):

@oli there were only like 18 regressions in crater anyways

oli (Sep 24 2019 at 22:02, on Zulip):

if those are unique, that's a lot

centril (Sep 24 2019 at 22:02, on Zulip):

Not for a soundness hole

centril (Sep 24 2019 at 22:03, on Zulip):

We have closed holes with way more than 18

centril (Sep 24 2019 at 22:03, on Zulip):

and the more we delay, the worse it gets

RalfJ (Oct 09 2019 at 13:30, on Zulip):

Cc https://github.com/rust-lang/rust/issues/49206

RalfJ (Oct 09 2019 at 13:30, on Zulip):

yeah I have this somewhere on my stack but there were always so many other things to do...

RalfJ (Oct 09 2019 at 13:30, on Zulip):

also I was waiting for AST borrowck to go away because that was an annoying bit here

RalfJ (Oct 09 2019 at 13:31, on Zulip):

but that excuse is gone now thanks to @centril <3

centril (Oct 09 2019 at 13:31, on Zulip):

@RalfJ ah! ast_borrowck makes total sense

centril (Oct 09 2019 at 13:32, on Zulip):

I had the same excuse wrt. or-patterns and not implementing crap for ast_borrowck in relation to that :slight_smile:

Last update: Nov 15 2019 at 20:20UTC