What is the point of the
ident function in tests like https://github.com/rust-lang/rust/blob/master/src/test/run-pass/const-int-overflowing.rs ?
We sometimes have this to avoid promotion of the argument, but here the argument is a constant so there is nothing to compute anyway... so why would we even care?
it's not just promotion, but also const propagation. If we const propagate enough, then even the comparison may get optimized out at some point. In the case you linked I think it's just coming from the other tests that actually compute something.
most of these
const-int tests don't compute anything
and const propagation will not stop just because something is the argument to a function.
so you agree I can remove
ident for cases where nothing gets computed?
oh, also -- shouldn't that test be in the
run-pass has such a folder
I think there's a
we are very consistent with naming things