woah GitHub seems really broken currently. I tried to close and reopen the PR but even that did not help.
and it still shows the PR as open though I closed it twice. wtf.
it still says the PR is not mergeable even though it is a fast-forward from master?!?
oh I guess this explains it: https://status.github.com/messages
Could you please make mod stacked_borrows public, so that I can use it in priroda?
Can't leave a review comment due to that github problem :)
@bjorn3 what do you want to do with it? this is heavily WIP
(weird, the user bjorn3 is gone now?)
anyway @Oli would be nice if you could have a look at https://github.com/solson/miri/pull/487 so we can merge later when github is unborked. latest commit in there should be 0b22a1c .
Github is so broken I can't even comment
I'll try again later
you can comment here ;)
What happens to immutable borrows in https://github.com/solson/miri/pull/487/files#diff-157b112a931b10b368e0e33da32c4a52R271
I neither know what should be happening nor why it results in a raw mut borrow without interior mut
the problem is cases like
then we want the memory covered by the first field to be treated with
Frz, but the 2nd field should have
So the entire thing becomes raw until we go further in?
though I just realized I didnt even think this through, the ref only has one tag
I assume the ref would have
Frz but that would be ignored for the
I should likely rename
well, figuring out what exactly to do is future work :)
Warrants a comment at least
and the comment is meant to indicate that there is work to be done. you want me to extend it?
Well move it onto the arm at least
I didn't figure out it only belonged to the second arm
Otherwise I think I understood all functions but I don't think I have a full grokking of the overall design yet
So r=me and I'll figure out things as they come
GH seems still broken? it doesnt trigger CI
yea, it's on and off all the time